Skip to content

Conversation

@jelmansouri
Copy link

The current code trigger a clang-cl warning when we moved to LLVM 14.

@jelmansouri
Copy link
Author

@Jake-Shadle, @repi, did Embark move to LLVM 14 yet?
Also I noticed that some other fixes were done directly on this repo 4.1 branches if you want me to try to upstream them first please tell me!

@repi repi requested a review from hrydgard April 30, 2022 16:26
@repi
Copy link

repi commented Apr 30, 2022

thanks!

@jelmansouri yes we are on Rust 1.60 which I believe includes LLVM 14, haven't seen this warning though when building through physx-rs. not sure why.

upstreaming to Nvidia repo unfortunately seems a bit hopeless, they haven't merged most fixes. So think merging in here and updating physx-rs would work. though feel free to attempt a PR on the Nvidia repo, maybe you'll have more luck with it!

@hrydgard added you here as you are codeowner on physx-rs and we don't have anyone else on this fork repo

@jelmansouri
Copy link
Author

@jelmansouri yes we are on Rust 1.60 which I believe includes LLVM 14, haven't seen this warning though when building through physx-rs. not sure why.

The update of the C++ compiler is separate in our case, we can use 1.60 that uses LLVM 14 for codegen, but still rely on the a clang/LLVM 13 for linking and compiling any C++ code (or GCC for that matter). The issue started only when moving the C++ compiler to LLVM14 since I try to keep them in sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants