Skip to content

Implicitly split parameters through add_param, corrected encode events to support empty iterator input #51

Open
MattiasFredriksson wants to merge 13 commits intoEmbodiedCognition:masterfrom
MattiasFredriksson:221228_correct_reader_conversion
Open

Implicitly split parameters through add_param, corrected encode events to support empty iterator input #51
MattiasFredriksson wants to merge 13 commits intoEmbodiedCognition:masterfrom
MattiasFredriksson:221228_correct_reader_conversion

Conversation

@MattiasFredriksson
Copy link
Contributor

@MattiasFredriksson MattiasFredriksson commented Dec 28, 2022

Changes:

Notes:

  • Separated changes to follow PEP standard and .format() rules in a separate branch as it became a distraction from the other changes.
  • Writing parameters is slightly confusing, input expects Fortran format while reading returns data in C format. I have no intention to fix this until the remaining changes and documentation is merged.
  • Implicitly splitting parameters is slightly problematic since there is no function for reading them as a single parameter (e.g. see More POINT:LABELS #47 ).

@Peaj
Copy link

Peaj commented Jun 4, 2024

Is there any reason this has not been merged yet? Works perfectly for me fixing the issue with c3d files using more than 255 labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnboundLocalError: local variable 'i' referenced before assignment when shallow copying a c3d file with no events

2 participants