Skip to content

Overviewpage multistore#131

Open
ahuininga-orisha wants to merge 8 commits intobetafrom
feat-overviewpage-multistore
Open

Overviewpage multistore#131
ahuininga-orisha wants to merge 8 commits intobetafrom
feat-overviewpage-multistore

Conversation

@ahuininga-orisha
Copy link
Collaborator

This adds the ability to change an overviewpage for sprecific store views. So you can add translations etc.

Fixes #121

@jansentjeu
Copy link
Collaborator

@ahuininga-orisha Do you have test scenarios for me to test this in the admin?

@ahuininga-orisha
Copy link
Collaborator Author

@jansentjeu

  • Create an overviewpage in the admin
  • Edit the overview page
  • Switch to an different storview while editing
  • change the url (and other data)
  • Save the changes for that specific storeview.
  • Check on the frontend if the overview page works for that storeview on that url, and you see the changes made for that storeview
  • Check if the overviewpage works in the frontend for other storeviews with the orginal data.

Copy link
Collaborator

@jansentjeu jansentjeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge the beta branch into this branch? Then you can run vendor/bin/grumphp run --ansi. It will run the new code checks

Copy link
Collaborator

@jansentjeu jansentjeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahuininga-orisha Did you test the latest changes? When i run setup:upgrade i get an error message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants