Implemented Emico Code Quality module

.github/workflows/grumphp.yaml

@@ -16,7 +16,8 @@ jobs:
       - name: GrumPHP
         run: |
           composer2 config http-basic.repo.magento.com ${{ secrets.MAGENTO_USERNAME }} ${{ secrets.MAGENTO_PASSWORD }}
+          composer2 config gitlab-token.git.emico.io ${{ secrets.GITLAB_TOKEN }}
           composer2 install --dev --prefer-dist --no-scripts --no-progress --optimize-autoloader --no-interaction -vvv
           composer2 show
-          vendor/bin/grumphp run --no-interaction
+          vendor/bin/grumphp run --tasks=phpmd,phpcs,xmllint,phplint,composer --no-interaction
         shell: bash

.gitignore

@@ -1,6 +1,7 @@
 /.idea
 /vendor
 /composer.lock
+/auth.json
 
 /build/local.env
-/build/data
+/build/data

.grumphpinclude

@@ -0,0 +1,3 @@
+# Add all files which should be included in here.
+# Patterns are equal to .gitignore
+*.php

composer.json

@@ -12,11 +12,7 @@
     },
     "require-dev": {
         "magento/framework": "*",
-        "phpro/grumphp-shim": "^2.7",
-        "squizlabs/php_codesniffer": "^3.10",
-        "phpmd/phpmd": "^2.15",
-        "slevomat/coding-standard": "^8.15",
-        "magento-ecg/coding-standard": "^4.5"
+        "emico/code-quality": "^10.5"
     },
     "autoload": {
         "files": [
@@ -26,17 +22,26 @@
             "Tweakwise\\TweakwiseJs\\": "src/"
         }
     },
-    "repositories": [
-        {
+    "repositories": {
+        "magento": {
             "type": "composer",
             "url": "https://repo.magento.com/"
+        },
+        "emico/code-quality": {
+            "type": "vcs",
+            "url": "https://git.emico.io/composer-packages/generic/codequality.git"
         }
-    ],
+    },
     "config": {
         "allow-plugins": {
-            "phpro/grumphp-shim": true,
             "magento/composer-dependency-version-audit-plugin": false,
-            "dealerdirect/phpcodesniffer-composer-installer": true
+            "dealerdirect/phpcodesniffer-composer-installer": true,
+            "phpstan/extension-installer": true,
+            "emico/code-quality": true,
+            "phpro/grumphp": true
+        },
+        "preferred-install": {
+            "emico/code-quality": "dist"
         }
     }
 }

grumphp.yml

@@ -1,11 +1,140 @@
 grumphp:
-    tasks:
-      xmllint:
-        triggered_by: ['xml', 'xsd']
-        scheme_validation: true
-        x_include: true
-        dtd_validation: true
-      phpcs: ~
-      phpmd:
-        ruleset:
-          - "ruleset.xml"
+  process_timeout: 360
+  extensions:
+    - Emico\CodeQuality\GrumPHP\Extension
+  parallel:
+    enabled: false
+  tasks:
+    phpstan:
+      triggered_by:
+        - php
+      level: 7
+      ignore_patterns:
+        - "vendor"
+        - "generated"
+        - "setup"
+        - "update"
+        - "dev"
+        - "tests"
+        - "public"
+        - "backend/vendor"
+        - "backend/generated"
+        - "backend/setup"
+        - "backend/update"
+        - "backend/tests"
+        - "backend/dev"
+        - "deploy.php"
+        - "deploy"
+        - "magento/vendor"
+        - "magento/generated"
+        - "magento/setup"
+        - "magento/update"
+        - "magento/tests/_support/_generated"
+        - "magento/dev"
+        - "LocalValetDriver.php"
+      configuration: phpstan.neon
+    phpmd:
+      triggered_by:
+        - php
+      ruleset:
+        - "ruleset.xml"
+      exclude:
+        - "vendor"
+        - "generated"
+        - "setup"
+        - "update"
+        - "dev"
+        - "public"
+        - "deploy"
+        - "tests/_support/_generated"
+        - "app/etc/config.php"
+        - "backend/vendor"
+        - "backend/generated"
+        - "backend/setup"
+        - "backend/update"
+        - "backend/update"
+        - "backend/dev"
+        - "backend/tests/_support/_generated"
+        - "backend/app/etc/config.php"
+        - "magento/app/etc/config.php"
+        - "magento/vendor"
+        - "magento/generated"
+        - "magento/setup"
+        - "magento/update"
+        - "magento/tests/_support/_generated"
+        - "magento/dev"
+    phpcs:
+      triggered_by:
+        - php
+      ignore_patterns:
+        - "vendor"
+        - "generated"
+        - "setup"
+        - "update"
+        - "dev"
+        - "public"
+        - "deploy"
+        - "tests/_support/_generated"
+        - "app/etc/config.php"
+        - "backend/vendor"
+        - "backend/generated"
+        - "backend/setup"
+        - "backend/update"
+        - "backend/dev"
+        - "backend/tests/_support/_generated"
+        - "backend/app/etc/config.php"
+        - "magento/app/etc/config.php"
+        - "magento/vendor"
+        - "magento/generated"
+        - "magento/setup"
+        - "magento/update"
+        - "magento/tests/_support/_generated"
+        - "magento/dev"
+
+    xmllint:
+      triggered_by: [ 'xml', 'xsd' ]
+      scheme_validation: true
+      x_include: true
+      dtd_validation: true
+      load_from_net: true
+
+    phplint:
+      short_open_tag: true
+      ignore_patterns:
+        - "vendor"
+        - "generated"
+        - "setup"
+        - "update"
+        - "dev"
+        - "public"
+        - "deploy"
+        - "tests/_support/_generated"
+        - "app/etc/config.php"
+        - "backend/vendor"
+        - "backend/generated"
+        - "backend/setup"
+        - "backend/update"
+        - "backend/dev"
+        - "backend/tests/_support/_generated"
+        - "backend/app/etc/config.php"
+        - "magento/app/etc/config.php"
+        - "magento/vendor"
+        - "magento/generated"
+        - "magento/setup"
+        - "magento/update"
+        - "magento/tests/_support/_generated"
+        - "magento/dev"
+
+    composer:
+      no_check_publish: true
+      with_dependencies: false
+      strict: false
+
+    git_commit_message:
+      allow_empty_message: false
+      enforce_capitalized_subject: false
+      enforce_no_subject_punctuations: false
+      enforce_no_subject_trailing_period: false
+      enforce_single_lined_subject: true
+      max_body_width: 100
+      max_subject_width: 100

phpcs.xml

@@ -0,0 +1 @@
+vendor/emico/code-quality/config-templates/magento/phpcs.dist.xml

phpstan.neon

@@ -0,0 +1,28 @@
+services:
+    - class: Emico\CodeQuality\PHPStan\VarModelExtension
+      tags:
+          - phpstan.broker.methodsClassReflectionExtension
+
+parameters:
+    ignoreErrors:
+        - '/Call to an undefined method Mockery\\ExpectationInterface|Mockery\\HigherOrderMessage::andReturnUsing\(\)./'
+        - '/expects string, Magento\\Framework\\Phrase given/'
+        - identifier: missingType.iterableValue
+        - identifier: missingType.generics
+        - messages:
+            - '/::delete\(\) expects Magento\\Framework\\Model\\AbstractModel,/'
+            - '/::save\(\) expects Magento\\Framework\\Model\\AbstractModel,/'
+            - '/::load\(\) expects Magento\\Framework\\Model\\AbstractModel,/'
+          path: *Repository.php
+    stubFiles:
+        - ./vendor/emico/code-quality/phpstan/stubs/globalFunctions.stub
+        - ./vendor/emico/code-quality/phpstan/stubs/Magento/Catalog/Model/ResourceModel/Product/Collection.stub
+        - ./vendor/emico/code-quality/phpstan/stubs/Magento/Eav/Setup/EavSetup.stub
+        - ./vendor/emico/code-quality/phpstan/stubs/Magento/Framework/Api/Search/FilterGroupBuilder.stub
+        - ./vendor/emico/code-quality/phpstan/stubs/Magento/Framework/App/ActionFlag.stub
+        - ./vendor/emico/code-quality/phpstan/stubs/Magento/Framework/Escaper.stub
+        - ./vendor/emico/code-quality/phpstan/stubs/Magento/Framework/Serialize/SerializerInterface.stub
+        - ./vendor/emico/code-quality/phpstan/stubs/Magento/InventoryImportExport/Model/Import/Serializer/Json.stub
+    bootstrapFiles:
+        - ../../autoload.php
+