New SkVisionStrictFormatCleanPdfDocument Connector#150
Merged
vmunoz96 merged 4 commits intoEncamina:mainfrom Jul 3, 2025
MarioRamosEs:@mramos/SkVisionStrictFormatCleanPdfDocumentConnector
Merged
New SkVisionStrictFormatCleanPdfDocument Connector#150vmunoz96 merged 4 commits intoEncamina:mainfrom MarioRamosEs:@mramos/SkVisionStrictFormatCleanPdfDocumentConnector
SkVisionStrictFormatCleanPdfDocument Connector#150vmunoz96 merged 4 commits intoEncamina:mainfrom
MarioRamosEs:@mramos/SkVisionStrictFormatCleanPdfDocumentConnector
Conversation
EXT97937
previously approved these changes
Apr 8, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 9 out of 13 changed files in this pull request and generated 3 comments.
Files not reviewed (4)
- Directory.Build.props: Language not supported
- Enmarcha.sln: Language not supported
- samples/SemanticKernel/Encamina.Enmarcha.Samples.SemanticKernel.DocumentContentExtractor/Encamina.Enmarcha.Samples.SemanticKernel.DocumentContentExtractor.csproj: Language not supported
- samples/SemanticKernel/Encamina.Enmarcha.Samples.SemanticKernel.DocumentContentExtractor/appsettings.json: Language not supported
...archa.SemanticKernel.Connectors.Document/Connectors/StrictFormatCleanPdfDocumentConnector.cs
Show resolved
Hide resolved
...manticKernel.Connectors.Document/Connectors/SkVisionStrictFormatCleanPdfDocumentConnector.cs
Show resolved
Hide resolved
...manticKernel.Connectors.Document/Connectors/SkVisionStrictFormatCleanPdfDocumentConnector.cs
Show resolved
Hide resolved
albertodiazencamina
requested review from
EXT97937
and removed request for
EXT97937
albertodiazencamina
dismissed
EXT97937’s stale review
He's not a valid reviewer
santypr
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkVisionStrictFormatCleanPdfDocumentConnector, which extendsStrictFormatCleanPdfDocumentConnector:ProcessPageExtensions(Page page)inStrictFormatCleanPdfDocumentConnector, allowing derived classes to append custom content blocks to the extracted page content.Encamina.Enmarcha.Samples.SemanticKernel.DocumentContentExtractor, demonstrating how to extract content from documents using Semantic Kernel connectors and vision capabilities..docx,.pptx,.txt,.md,.jpg,.jpeg,.png, and.pdffiles.SkVisionImageExtractorclass, which centralizes image processing logic using vision models (via Semantic Kernel). This enhances code reuse and promotes separation of concerns.SkVisionImageDocumentConnectorto inherit fromSkVisionImageExtractor, simplifying the implementation and removing redundant logic.