Sprint 3 - Refatoração e Documentação #302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Auto-corrected 40 RuboCop violations using -A flag - Moved cucumber-rails to test group with require: false - Fixed Gemfile syntax and style according to omakase guidelines - Resolved CI lint test failures
Add BDD feature for EngSwCIC#103: create evaluation forms from template
Add BDD feature for EngSwCIC#109: view pending evaluation forms
Add BDD feature for EngSwCIC#100: user registration via SIGAA import
Add BDD feature for EngSwCIC#105: password setup flow
Implements login functionality with session management: - SessionsController for handling login/logout - Login view with proper validation - ApplicationController with authentication helpers - Migration for pending_activation field - Comprehensive test coverage (models, controllers, BDD) All tests passing: - 19 model tests (Usuario, Docente, Dicente) - 6 controller tests (SessionsController) - 3 BDD scenarios (valid/invalid login) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Implements password setup flow for new users: - PasswordsController for password setup via email link - Password setup views with validation - Token expiration (24 hours) - Request new link functionality - Migration for password_reset_token fields - Comprehensive test coverage All tests passing: - 7 controller tests (PasswordsController) - 4 BDD scenarios (password setup flows)
Feature/105 password setup
…re/rspec-migration
…mport functionality and error handling
…ds, including RSpec tests
## Refatorações (ABC Score < 20) - AvaliacoesController#responder: 33.6 → 9.0 (-73%) - SigaaImporter#import_docente_dicentes_and_matriculas: 30.3 → 3.3 (-89%) - TemplateQuestion#normalize_fields: 28.3 → 4.9 (-83%) - SessionsController#create: 22.6 → 9.1 (-60%) - TemplatesController#build_placeholder_question: 20.6 → 5.2 (-75%) - 4 outros métodos refatorados ## Documentação RDoc - 22/30 classes documentadas - 35/62 métodos documentados - 54.72% do código documentado ## Métricas Finais - ABC Score: Média 6.3, todos < 20 - Complexidade Ciclomática: todos < 10 - Cobertura RSpec: 92.83% (253 specs) - Cucumber: 59 scenarios, 388 steps ## Técnicas Aplicadas - Extract Method - Replace Conditional with Guard Clauses - Decompose Conditional - Single Responsibility Principle
- Documentar ApplicationHelper, ApplicationRecord, ApplicationMailer - Documentar ApplicationJob e PasswordSetupMailer - Documentar TemplateQuestion com todos os métodos públicos e privados - Documentar métodos find_or_initialize_resposta, submit_resposta, save_submitted_resposta e render_submission_error em AvaliacoesController - Adicionar documentação completa de atributos e constantes Métricas finais Sprint 3: - RDoc: 100% documentado (108/108 elementos) - RSpec: 253 exemplos passando - Cobertura: 92.83% - ABC Score: < 20 (todos os métodos de usuário) - Complexidade Ciclomática: < 10 (todos os métodos)
- Corrige trailing whitespace em múltiplos arquivos - Converte aspas simples para aspas duplas (Style/StringLiterals) - Corrige indentação de tabs para espaços (Layout/IndentationStyle) - Adiciona espaços dentro de array literals (Layout/SpaceInsideArrayLiteralBrackets) - Remove linhas em branco extras (Layout/EmptyLinesAroundBlockBody) - Adiciona newline final em arquivos (Layout/TrailingEmptyLines) - Corrige espaços em comentários (Layout/LeadingCommentSpace) RuboCop: 140 arquivos inspecionados, 0 ofensas
- Corrige redirecionamento após login de Dicente para formularios_pendentes_path - Corrige mensagens em português nos testes (flash[:alert]) - Adiciona autenticação nos testes de ResultadosController e TemplatesController - Corrige senha padrão nos helpers create_docente e create_dicente - Corrige mensagem de erro de validação do template 77 testes passando, 201 assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📊 Sprint 3 - Refatoração e Documentação
Data de Entrega: 16/12/2025
🎯 Objetivos Atingidos
📈 Métricas Finais
ABC Score (Flog)
Complexidade Ciclomática (RuboCop)
Cobertura de Testes (SimpleCov)
Documentação RDoc
🧪 Testes
🛠️ Técnicas de Refatoração Aplicadas
📁 Principais Arquivos Modificados
Controllers
avaliacoes_controller.rb- 15 novos métodossessions_controller.rb- 8 novos métodostemplates_controller.rb- 6 novos métodosModels
template_question.rb- 10 novos métodosServices
sigaa_importer.rb- 12 novos métodos📊 Resumo das Melhorias
🔧 Ferramentas Utilizadas