Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/ubergraph/core.clj
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,8 @@ will `upgrade' the directed edge to undirected and merge attributes."

(defn- find-edges-impl
([g src dest]
(get-in g [:node-map src :out-edges dest]))
(map #(with-meta % g)
(get-in g [:node-map src :out-edges dest])))
([g {src :src dest :dest :as attributes}]
(let [edges
(cond
Expand All @@ -353,11 +354,12 @@ will `upgrade' the directed edge to undirected and merge attributes."
dest (in-edges g dest)
:else (edges g))
attributes (dissoc attributes :src :dest)]
(if (pos? (count attributes))
(for [edge edges
:when (submap? attributes (get-in g [:attrs (:id edge)]))]
edge)
edges))))
(map #(with-meta % g)
(if (pos? (count attributes))
(for [edge edges
:when (submap? attributes (get-in g [:attrs (:id edge)]))]
edge)
edges)))))

(defn- find-edge-impl [& args]
(first (apply find-edges-impl args)))
Expand Down
43 changes: 43 additions & 0 deletions test/ubergraph/core_test.clj
Original file line number Diff line number Diff line change
Expand Up @@ -353,3 +353,46 @@
;; This will use calculated hashes during =, but should still be
;; true.
(is (= g2 g1))))


(defn all-edges-with-meta-g [g edges]
(every? (fn [e]
(and (edge? e)
(= g (meta e))))
edges))


(defn check-all-edge-returning-fns [g]
(let [es1 (edges g)
es2 (out-edges g 1)
es3 (in-edges g 3)
es4 (find-edges g 2 3)
es5 (find-edges g {:src 2 :dest 3})
es6 (find-edge g 2 3)
es7 (find-edge g {:src 2 :dest 3})]
(is (> (count es1) 0))
(is (= true (all-edges-with-meta-g g es1)))
(is (> (count es2) 0))
(is (= true (all-edges-with-meta-g g es2)))
(is (> (count es3) 0))
(is (= true (all-edges-with-meta-g g es3)))
(is (> (count es4) 0))
(is (= true (all-edges-with-meta-g g es4)))
(is (> (count es5) 0))
(is (= true (all-edges-with-meta-g g es5)))

(is (not (nil? es6)))
(is (= true (all-edges-with-meta-g g [es6])))
(is (not (nil? es7)))
(is (= true (all-edges-with-meta-g g [es7])))))


(deftest returned-edge-objects-contain-g-in-metadata
(let [g1 (graph [1 2] [1 3] [2 3] 4)
g2 (digraph [1 2] [1 3] [2 3] 4)
g3 (multigraph [1 2] [1 2] [2 1] [1 3] [2 3] [2 3] 4)
g4 (multidigraph [1 2] [1 2] [1 2] [2 1] [1 3] [2 3] [2 3] 4)]
(check-all-edge-returning-fns g1)
(check-all-edge-returning-fns g2)
(check-all-edge-returning-fns g3)
(check-all-edge-returning-fns g4)))