add option to modify gpio base path for testing purposes#40
add option to modify gpio base path for testing purposes#40sa-linetco wants to merge 5 commits intoEnotionZ:masterfrom
Conversation
|
Maybe you'll be interested in: |
|
Please rebase and send cleanup patches separately. |
d09a3f3 to
a114ce2
Compare
|
@rzr there you go :) |
|
Thx, |
|
From a software design perspective, I think it makes more sense to set the base directory path on the class method. On an instance level, the test option should be the filename which contains the value rather than the directory. Also this is probably unintentional but the entire package.json file is overridden which may cause reference problems when it's publish in npm. |
rzr
left a comment
There was a problem hiding this comment.
please keep the var vs const and fix conflict then I think it can be mergeable
| const defaultGpioBasePath = '/sys/class/gpio/'; | ||
|
|
||
| var logError = function (e) { | ||
| function logError(e) { |
rzr
left a comment
There was a problem hiding this comment.
please split this PR in several PR with smaller changes
| "name": "gpio", | ||
| "version": "0.4.0", | ||
| "author": { | ||
| "name": "Sebastian Alkemade", |
There was a problem hiding this comment.
do we want to change author ? here
|
Please try to split this change is smaller PR |
|
Is there any interest to upstream this for next release ? |
|
Maybe you can try to demonstrate this by controlling on board leds : ie emulate actions in: would be forwarded to: does it make sense ? |
No description provided.