-
Notifications
You must be signed in to change notification settings - Fork 10
adapted phylogenomics code to changes in Compara TSV files #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brunocontrerasmoreira
merged 11 commits into
Ensembl:master
from
brunocontrerasmoreira:master
Aug 28, 2025
Merged
adapted phylogenomics code to changes in Compara TSV files #16
brunocontrerasmoreira
merged 11 commits into
Ensembl:master
from
brunocontrerasmoreira:master
Aug 28, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
JAlvarezJarreta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far. Just a couple of minor edits, including reverting a few "unexpected" changes.
Co-authored-by: Jorge Alvarez-Jarreta <jalvarez@ebi.ac.uk>
Co-authored-by: Jorge Alvarez-Jarreta <jalvarez@ebi.ac.uk>
Co-authored-by: Jorge Alvarez-Jarreta <jalvarez@ebi.ac.uk>
Co-authored-by: Jorge Alvarez-Jarreta <jalvarez@ebi.ac.uk>
Co-authored-by: Jorge Alvarez-Jarreta <jalvarez@ebi.ac.uk>
Co-authored-by: Jorge Alvarez-Jarreta <jalvarez@ebi.ac.uk>
Collaborator
Author
|
Acepted your edits @JAlvarezJarreta |
JAlvarezJarreta
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code edits in this PR adapt the scripts in phylogenomics/ to the Compara TSV files downloaded at runtime. The most important change is that now the bulky Plants Multi-species file is used, as only this file contains orthologues for all pairs of plant species. This file is available for the latest release at:
The scripts have been tested on two different clades. For the record, they are mentioned in a book chapter published in 2022: https://link.springer.com/protocol/10.1007/978-1-0716-2067-0_2