feature/13-layered-to-hexagonal-auth by qkrwndnjs1075 · Pull Request #21 · EntryDSM/Casper-User

qkrwndnjs1075 · 2025-07-28T07:02:11Z

auth 관련 비즈니스 로직 PR

coderabbitai · 2025-07-28T07:02:18Z

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch feature/13-layered-to-hexagonal-auth

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

devizi0 · 2025-07-29T08:11:57Z

.../kotlin/hs/kr/entrydsm/user/domain/auth/adapter/in/web/dto/resopnse/QueryPassInfoResponse.kt

패키지명 resopnse 오타입니다. response로 수정하세요 @qkrwndnjs1075

수정했습니다

devizi0 · 2025-07-29T08:12:35Z

...user/src/main/kotlin/hs/kr/entrydsm/user/domain/auth/application/service/PassPopupService.kt

+
+            return htmlBuilder.toString()
+        } catch (e: Exception) {
+            println(e.message)


println 말고 로거 사용이 적절해 보이는데 확인부탁드립니다 @qkrwndnjs1075

bbf106f 수정했습니다

devizi0 · 2025-07-29T08:13:20Z

casper-user/src/main/kotlin/hs/kr/entrydsm/user/domain/auth/adapter/out/PassInfo.kt

+@RedisHash
+class PassInfo(
+    @Id
+    val name: String,


사용자 이름을 키로 잡는 로직에서 동명이인이 동시에 사용시 안전한가요? @qkrwndnjs1075

그럼 @id를 그냥 phoneNumber로 할까요 그게 나을 것 같은데

네 그게 더 좋을껏 같네요

d4ede1b phoneNumberHash로 하도록 변경

passInfo도 암호화 되어야 하기 때문에 Hash 기준으로 find 하도록 수정
4b9ba22

devizi0 · 2025-07-29T08:14:21Z

casper-user/src/main/kotlin/hs/kr/entrydsm/user/domain/refreshtoken/adapter/out/RefreshToken.kt

+        token: String?,
+        ttl: Long,
+    ) {
+        this.token = token!!


null이 들어왔을때 대응 로직이 있을까요 ? @qkrwndnjs1075

non-null 캐스트 제거 했습니다. ( 과거의 유산 )

qkrwndnjs1075 added 7 commits July 28, 2025 15:00

feat ( #13 ) : application in/port 추가

7f95e56

feat ( #13 ) : application service 추가

d85f1a4

feat ( #13 ) : in/web 추가

51a12d4

feat ( #13 ) : in/web dto 추가

6332078

feat ( #13 ) : adapter/out 추가

b0d6809

feat ( #13 ) : add gitkit

81f784e

feat ( #13 ) : adapter/out 추가 [ refreshToken ]

1263db5

qkrwndnjs1075 self-assigned this Jul 28, 2025

qkrwndnjs1075 requested review from coehgns and kangeunchan July 28, 2025 07:02

qkrwndnjs1075 added the Feature label Jul 28, 2025

devizi0 requested changes Jul 29, 2025

View reviewed changes

qkrwndnjs1075 added 2 commits July 29, 2025 18:35

refactor ( #13 ) : @id를 name에서 phoneNumber로 변경

f245912

refactor ( #13 ) : phoneNumberHash로 조회할 수 있게 변경

d4ede1b

devizi0 approved these changes Jul 30, 2025

View reviewed changes

qkrwndnjs1075 added 2 commits July 30, 2025 15:49

refactor ( #13 ) : logger를 사용하도록 변경

bbf106f

refactor ( #13 ) : 왜 있는 지 모를 non-null 캐스트 제거

e7b2e1e

qkrwndnjs1075 requested a review from devizi0 July 30, 2025 07:09

coehgns approved these changes Jul 31, 2025

View reviewed changes

qkrwndnjs1075 merged commit c7d30f6 into main Aug 1, 2025
1 check passed

qkrwndnjs1075 deleted the feature/13-layered-to-hexagonal-auth branch August 1, 2025 06:53

Conversation

qkrwndnjs1075 commented Jul 28, 2025

Uh oh!

coderabbitai bot commented Jul 28, 2025

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

CodeRabbit Configuration File (`.coderabbit.yaml`)