Allow complex and double precision HEALPix#235
Draft
nicholebarry wants to merge 4 commits intomasterfrom
Draft
Conversation
Contributor
|
Yes, cross-pols will always be complex conjugates of one another. I'm concerned about the data volume increase if we make Healpix cubes complex. Does that apply to XX and YY as well? Then those Healpix cubes would be twice the size they need to be. One option is to keep the Healpix cubes real and output XX, YY, the real part of XY, and the imaginary part of XY. This is what we do for the integrated images. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch has the basic requirements for being able to create cross-pol Healpix cubes.
It uses the type of the image to determine the type of the Healpix cube (i.e. double, float, real, complex). However, this results in slightly bulky code...checking the type means using a 4 case statement each time. Is there a better way to do it?
This is also not as efficient as it could be. @rlbyrne I remember you saying that the cross-pols are complex conjugates of one another (I think?). Is this always the case, not just for current code, but for most instrumentation and future parameters? If so, we could potentially get away with only writing out three cubes instead of all four.