Skip to content

Remove unused conserve_memory parameter from blackmanharris_decomp#340

Merged
nicholebarry merged 2 commits intoblackmannharris_beamsfrom
copilot/sub-pr-339
Feb 13, 2026
Merged

Remove unused conserve_memory parameter from blackmanharris_decomp#340
nicholebarry merged 2 commits intoblackmannharris_beamsfrom
copilot/sub-pr-339

Conversation

Copy link

Copilot AI commented Feb 13, 2026

Addresses review feedback on #339 to remove the unused conserve_memory parameter from blackmanharris_decomp.pro.

Changes

  • Removed conserve_memory keyword parameter from blackmanharris_decomp function signature
  • The parameter was declared but never referenced in the function body
  • gaussian_decomp continues to use this parameter; calling code in beam_decomp.pro remains unchanged as IDL ignores unrecognized keywords
FUNCTION blackmanharris_decomp, x, y, p, $
  ftransform=ftransform, model_npix=model_npix, model_res=model_res, over_res=over_res,$
- volume_beam=volume_beam, sq_volume_beam=sq_volume_beam, max_amp=max_amp, $
- conserve_memory=conserve_memory
+ volume_beam=volume_beam, sq_volume_beam=sq_volume_beam, max_amp=max_amp

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: nicholebarry <5588290+nicholebarry@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on Blackmannharris beams update Remove unused conserve_memory parameter from blackmanharris_decomp Feb 13, 2026
Copilot AI requested a review from nicholebarry February 13, 2026 04:43
@nicholebarry nicholebarry marked this pull request as ready for review February 13, 2026 04:50
@nicholebarry nicholebarry merged commit b27b6c1 into blackmannharris_beams Feb 13, 2026
@nicholebarry nicholebarry deleted the copilot/sub-pr-339 branch February 13, 2026 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants