Remove unused conserve_memory parameter from blackmanharris_decomp#340
Merged
nicholebarry merged 2 commits intoblackmannharris_beamsfrom Feb 13, 2026
Merged
Remove unused conserve_memory parameter from blackmanharris_decomp#340nicholebarry merged 2 commits intoblackmannharris_beamsfrom
nicholebarry merged 2 commits intoblackmannharris_beamsfrom
Conversation
Co-authored-by: nicholebarry <5588290+nicholebarry@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on Blackmannharris beams update
Remove unused conserve_memory parameter from blackmanharris_decomp
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #339 to remove the unused
conserve_memoryparameter fromblackmanharris_decomp.pro.Changes
conserve_memorykeyword parameter fromblackmanharris_decompfunction signaturegaussian_decompcontinues to use this parameter; calling code inbeam_decomp.proremains unchanged as IDL ignores unrecognized keywords💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.