feat: enhance EVM configuration and upgrade handling in EpixChain #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndency in test suite
- Resolved conflicts in Makefile to maintain epixd binary naming - Updated systemtests configuration to use epixd instead of evmd - Preserved EpixChain-specific upgrade handlers and configurations - Adopted upstream documentation improvements and test structure - Maintained EpixChain custom mint module and TopHolders functionality - Updated dependencies to match upstream versions
- Resolved conflicts in go.mod and go.sum to use updated dependencies - Restored systemtests client modifications - Added necessary imports for systemtests functionality
- Fixed missing import quotes in evmd/app.go (path/filepath) - Added cosmossdk.io/client/v2 dependency to resolve missing package error - Updated go.mod and go.sum with go mod tidy for both root and evmd directories - Resolves compilation errors in Solidity Test workflow
- Split line 210 in v0.4.0_to_v0.5.0.md into multiple lines - Resolves MD013/line-length error (line was 588 chars, max is 500) - Fixes Check Markdown links workflow failure
- Added Node.js setup and yarn dependency caching to solidity-test workflow - Implemented retry logic with exponential backoff for yarn install (3 attempts) - Resolves transient npm registry failures (500 Internal Server Error) - Improves workflow reliability and reduces flaky test failures
- Updated Node.js version from 18 to 20 in solidity-test workflow - Resolves yargs@18.0.0 engine incompatibility error - yargs requires Node.js ^20.19.0 || ^22.12.0 || >=23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the EVM chain configuration and improves upgrade handling for EpixChain, focusing on more robust configuration management and enhanced token metadata. The most significant changes include moving chain config initialization to the application layer, updating the upgrade handler for EpixChain v0.6.0, and refining how the chain ID is passed and used throughout the codebase.
Chain configuration management:
evmtypes.SetChainConfig) is now performed in the application layer (evmd/app.go) before creating the EVM keeper, instead of inside the keeper itself. This makes configuration more explicit and easier to manage. [1] [2]evmChainIDparameter is removed from the EVM keeper constructor (x/vm/keeper/keeper.goand its usage inevmd/app.go), reflecting the new approach to chain config setup. [1] [2]Upgrade handler and token metadata improvements:
evmd/upgrades.gois updated for EpixChain v0.6.0, including improved logging and enhanced denom metadata for the native token (aepix/epix). Extended denom options setup is skipped as EpixChain uses 18 decimals.Test and configuration consistency:
evmd/test_helpers.gonow sets the EVM chain ID in app options, ensuring tests use the correct configuration.