Merged
Conversation
Wrap expected warning-producing calls in expect_warning() so they don't leak during test runs. Make import_mat_to_db migration test self-contained by creating a MAT file via export_db_to_mat round-trip instead of depending on an external fixture file.
…PNGs Only logo.png is needed in the built package (for README). All other figures are referenced via absolute pkgdown URLs in vignettes. Also compress large screenshot PNGs by stripping metadata and resizing.
…ormat The save notification always showed the MAT output folder path, even when using SQLite storage. Now shows the appropriate message per format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expect_warning()and making the MAT migration test self-containedTest plan
devtools::test()passes with 0 warnings and 0 skips (on environments with Python/scipy)R CMD checkshows no new NOTEs about package size🤖 Generated with Claude Code