Iterable message dispatching

[frankdejonge]

No description provided.

[lgrossi]

I left some suggestions on possible ways to keep leveraging the generators and avoid dumping it to memory as much as possible, but overall the changes lgtm.

[lgrossi]

Are you sure this works for iterable? I have the impression that this will just return an empty array to the map function, no?

Maybe something like:

Suggested change

	array_map(fn (Message $message) => $this->decorator->decorate($message), (array) $messages)
	$decoratedMessages = (function () use ($messages): Generator {
	foreach ($messages as $message) {
	yield $this->decorator->decorate($message);
	}
	})();
	$this->dispatcher->dispatch($decoratedMessages);

[lgrossi]

It seems that this is also not covered by tests.

[lgrossi]

This will unpack the iterable fully to memory, right? I wonder if there is a way to achieve this by using only generators. I couldn't think on a straightforward way to do so.

[lgrossi]

To keep leveraging generators, maybe this could pass messages as a generator instead?

Suggested change

	foreach ($events as $event) {
	$messages[] = $this->decorator->decorate(new Message($event, $headers));
	}
	$messages = (function() use ($events, $headers): Generator {
	foreach ($events as $event) {
	yield $this->decorator->decorate(new Message($event, $headers));
	}
	})();

[lgrossi]

To continue to leverage generators, maybe $forwarded could always be a generator?

Suggested change

	$forwarded = [];
	$messages = is_iterable($messages) ? $messages : [$messages];
	$forwarded = (function () use ($messages): Generator {
	foreach ($messages as $message) {
	if (! $this->filterBefore->allows($message)) {
	continue;
	}
	$message = $this->translator->translateMessage($message);
	if (! $this->filterAfter->allows($message)) {
	continue;
	}
	yield $message;
	}
	})();