Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 9, 2026

The RGB logic in ap_dataloader_dali.py and data_decord_llava_vit.py was inverting color channels incorrectly. Since decord.VideoReader already returns RGB, the [:, :, :, ::-1] operation was converting RGB→BGR when use_rgb=True—the opposite of intended behavior.

Changes

  • Removed erroneous channel reversal from _load_video_data() in both files:
# Removed:
if self.use_rgb:
    video_data = video_data[:, :, :, ::-1]
Original prompt

dataloader/ap_dataloader_dali.py
dataloader/data_decord_llava_vit.py

这两个里面rgb的逻辑是错的,你给我删掉吧


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…_llava_vit.py

Co-authored-by: anxiangsir <31175974+anxiangsir@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove incorrect RGB logic from data loaders Remove incorrect RGB channel reversal logic from dataloaders Jan 9, 2026
Copilot AI requested a review from anxiangsir January 9, 2026 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants