Skip to content

Comments

Feature/logo size#85

Open
awesomejerry wants to merge 3 commits intomainfrom
feature/logo-size
Open

Feature/logo size#85
awesomejerry wants to merge 3 commits intomainfrom
feature/logo-size

Conversation

@awesomejerry
Copy link
Contributor

No description provided.

@renatobenks
Copy link

renatobenks commented Feb 20, 2020

hey @awesomejerry what else is missing to move forward with this and merge it?

@awesomejerry
Copy link
Contributor Author

Nothing really. Just not sure if it's a needed feature for this library though. What do you think? Is it a must-have feature?

@AzzouQ AzzouQ mentioned this pull request Apr 30, 2020
@AzzouQ
Copy link

AzzouQ commented Apr 30, 2020

@awesomejerry You should also add TS definition, I think that logoSize?: number | {width: number, height: number}; in index.d.ts should do it ? It will allow us to render not square logo with this PR. Great work.

@michaelyiu
Copy link

would love to see this merged as this is the exact case im looking for this package @awesomejerry if you're still maintaining it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants