Fix: mapViews metadata sync fails with ConstraintViolationException due to duplicate key

[nshandra]

Links

Task: [1209] Test maps synchronization
Jira: Map synchronization fails with ConstraintViolationException due to duplicate key

Description

The code of the PR referenced in the task is not used when running syncs, instead is used for Metadata dependency export of Dasboards.

The metadata version object is created by DefaultMetadataExportService.getMetadataAsObjectNode. Issue is that it includes both Map and MapView objects.

Now, before importing the received metadata, the standalone MapView objects are filtered to remove the mapViews present in Maps.

[tokland]

Code looks good. I just added a comment about where filterMapViewObjects should be called. My only concern is that it feels a bit odd that this is the only post-processing done in this file, so I’m not sure this is where upstream would place it. I checked calls from getMetadata, and it doesn’t seem like queryService performs any post-processing either. So we can keep it as is for now and see how upstream approaches it.

[tokland]

Should this be invoked at a lower point (getMetadata?) so that any caller receives already filtered metadata without needing post-processing?

[nshandra]

Good catch, it also happens when exporting and importing metadata. Initially i didn't catch it because it works fine when updating existing metadata but fails when creating new objects. I updated the Jira ticket and moved the filtering to the import service.