Skip to content
This repository was archived by the owner on Dec 14, 2025. It is now read-only.

Conversation

@RamesTheGeneric
Copy link
Contributor

Updated Configuration for the babble board and added an AEC value adjustment for it.

@lorow
Copy link
Member

lorow commented Dec 21, 2024

Overall looks good!

One question though, CONFIG_CAMERA_MODULE_SWROOM_BABBLE_S3 seems to be missing in boards.ini, is that how it should be? If not:

build_flags = ${env.build_flags}
                       -DCONFIG_CAMERA_MODULE_SWROOM_BABBLE_S3 
                       // rest of the flags

should do the trick

@RamesTheGeneric
Copy link
Contributor Author

DCONFIG_CAMERA_MODULE_SWROOM_BABBLE_S3 is defined in pinouts.ini I believe this has remained untouched since the last pr.

@lorow
Copy link
Member

lorow commented Dec 21, 2024

Oh yeah, my bad, I misread it as a different config option, I'll merge and release it tomorrow then. I still have to upgrade some hooks to fix releases

@RamesTheGeneric
Copy link
Contributor Author

RamesTheGeneric commented Dec 23, 2024

I have discovered more changes I need to make before this can be merged, please hold off on merging this. Sorry about this.

@RamesTheGeneric
Copy link
Contributor Author

Hello, I have been testing these changes on my own for the past several days and I believe it is ready to be merged.

@lorow
Copy link
Member

lorow commented Jan 9, 2025

Gotcha, sorry for the delay too. Looks like I'll have to fix the CI/CD pipeline first , but the changes look good. I'll take of it today

@lorow lorow changed the base branch from master to beta January 11, 2025 19:24
@lorow lorow merged commit 056e19f into EyeTrackVR:beta Jan 11, 2025
24 of 25 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants