Working OIDC auth

[cofob]

No description provided.

[MikeWent]

this should use entity_service.create

[cofob]

@copilot fix this

[cofob]

@MikeWent copilot fixed this

[cofob]

@copilot fix all requested changes

[Copilot]

Pull Request Overview

This PR adds OpenID Connect (OIDC) authentication support to both the Flask UI and FastAPI backend, including a UI login link, proxy endpoints, dedicated API routes, configuration options, and documentation updates.

• Added an OIDC login button and proxy endpoints in the Flask auth controller
• Integrated Authlib-based OIDC routes in the FastAPI backend and registered a new router
• Updated environment examples, dependencies, and documentation for OIDC setup

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
ui/app/templates/auth/login.jinja2	UI template: added “Login with OpenID Connect” button
ui/app/controllers/auth.py	Flask auth controller: proxy to OIDC backend and cookie strip
secrets.env.example	Included OIDC environment variables
pyproject.toml	Added authlib dependency
api/app/services/entity.py	New get_by_oidc_email method for entity lookup
api/app/routes/token.py	Extended token endpoints for OIDC login and callback
api/app/routes/oidc.py	New standalone OIDC authentication routes
api/app/config.py	Config class extended with OIDC settings
api/app/app.py	Registered OIDC router and session middleware
README.md	Documented OIDC setup steps

Comments suppressed due to low confidence (5)

api/app/routes/oidc.py:1

• New OIDC routes have been introduced but no tests were added. Consider adding unit or integration tests for the login and callback endpoints to verify correct behavior.

"""OIDC (OpenID Connect) authentication endpoints"""

pyproject.toml:8

• The Flask auth controller now imports requests, but requests is not listed in pyproject.toml dependencies. Add e.g. "requests>=2.28.0" to ensure the package installs correctly.

    "authlib>=1.6.0",

api/app/services/entity.py:68

• func is used for json_extract but not imported in this module. Add from sqlalchemy import func to avoid a NameError at runtime.

            .filter(func.json_extract(self.model.auth, "$.oidc_email") == email)

api/app/routes/token.py:41

• request.url_for("oidc_callback") may not resolve correctly because this endpoint is in the token router; use request.url_for("token.oidc_callback") or app.url_path_for with the correct router name.

    redirect_uri = config.oidc_redirect_uri or str(request.url_for("oidc_callback"))

api/app/config.py:29

• The Config class uses field(...) but there's no import for field; add the correct import (from dataclasses import field or the Pydantic equivalent) to avoid NameError.

    oidc_client_id: str | None = field(default=getenv("REFINANCE_OIDC_CLIENT_ID", ""))

[Copilot]

[nitpick] Catching the base Exception is too broad and may hide unexpected errors; narrow this to specific exceptions (e.g., NotFoundError) to improve error handling.

Suggested change

	except Exception:
	pass
	except KeyError: # Replace with the specific exception(s) raised by get_by_name
	# Log the error for visibility
	print(f"Entity not found for email: {email}") # Replace with proper logging if available

[gitguardian]

⚠️ GitGuardian has uncovered 6 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
18717092	Triggered	Generic Password	b8967ac	authelia/config/users_database.yml	View secret
18717093	Triggered	Generic High Entropy Secret	b8967ac	authelia/config/configuration.yml	View secret
18287481	Triggered	Generic Password	6aea789	docker-compose.prod.yml	View secret
18717094	Triggered	Generic Password	b8967ac	authelia/config/users_database.yml	View secret
18717095	Triggered	Generic Private Key	b8967ac	authelia/config/configuration.yml	View secret
18717096	Triggered	Generic Private Key	b8967ac	authelia/https-localhost-proxy/certs/localhost.key	View secret

🛠 Guidelines to remediate hardcoded secrets

1. Understand the implications of revoking this secret by investigating where it is used in your code.
2. Replace and store your secrets safely. Learn here the best practices.
3. Revoke and rotate these secrets.
4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

• following these best practices for managing and storing secrets including API keys and other credentials
• install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

---

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}