Open
Conversation
mighty-mhsl
reviewed
Oct 29, 2023
| @@ -0,0 +1,7 @@ | |||
| package task_2.solution.exceptions; | |||
|
|
|||
| public class NoOrdersException extends Exception{ | |||
| package task_2.solution.exceptions; | ||
|
|
||
| public class NotEnoughMaterialException extends Exception{ | ||
| public NotEnoughMaterialException(String material) { |
| @@ -0,0 +1,7 @@ | |||
| package task_2.solution.exceptions; | |||
|
|
|||
| public class NotEnoughWoodException extends Exception{ | |||
| } | ||
|
|
||
| orders.add(order); | ||
| } |
| coreMaterialCount.put(coreMaterial, availableMaterialCount - requiredMaterialCount); | ||
| } else { | ||
| throw new NotEnoughMaterialException(coreMaterial); | ||
| } |
Contributor
There was a problem hiding this comment.
Дубликация кода. Вынести в приватный метод проверку наличия материалов в достаточном количестве
|
|
||
| orders.add(order); | ||
| } | ||
| public Wand findMostPowerfulWand() throws NoOrdersException{ |
| } | ||
| public Wand findMostPowerfulWand() throws NoOrdersException{ | ||
| if (orders.isEmpty()) { | ||
| throw new NoOrdersException("Заказы недоступны"); |
Contributor
There was a problem hiding this comment.
Возвращать пустой Optional, а не кидать исключение
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.