-
Notifications
You must be signed in to change notification settings - Fork 5
Merge All High Schoolers' PRs #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
zhan4329
wants to merge
72
commits into
FNLCR-DMAP:main
from
Saran-Nag:merge/high-school-prs-issue-7
Closed
Merge All High Schoolers' PRs #61
zhan4329
wants to merge
72
commits into
FNLCR-DMAP:main
from
Saran-Nag:merge/high-school-prs-issue-7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 1, 2025
Small fixes: - Update environment.yml to make it consistent with requirement.txt Comments: - Update .gitignore to include Jupyter section - Write clearer comments in Dockerfile; remove redundant comments Files clean up: - Remove redundant quickstart guide
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 1, 2025
Small fixes: - Update environment.yml to make it consistent with requirement.txt - Update README.md to include TA's name Comments: - Update .gitignore to include Jupyter section - Write clearer comments in Dockerfile; remove redundant comments Files clean up: - Remove redundant quickstart guide
fa81212 to
3dc2a08
Compare
small fixes - Update environment.yml to make it consistent with requirement.txt - Update README.md to include TA's name docs clean-up - Update .gitignore to include Jupyter section - Write clearer comments in Dockerfile; remove redundant comments - Remove redundant quickstart guide server files clean-up: anno_vs_anno_server.py, feat_vs_anno_server.py, nearest_neighbor_server.py, scatterplot_server.py ui files clean-up: anno_vs_anno_ui.py, annotations_ui.py, feat_vs_anno_ui.py, features_ui.py, scatterplot_ui.py
3dc2a08 to
53e8c5f
Compare
6 tasks
Contributor
Author
|
@georgezakinih Hi George, could you review this Pull Request for high schoolers' PRs as well as some other necessary changes done by us? Thank you! |
- Update SPAC package - Add comments to the two new packages
c0c4621 to
95d41db
Compare
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 5, 2025
small fixes - Update environment.yml to make it consistent with requirement.txt - Update README.md to include TA's name docs clean-up - Update .gitignore to include Jupyter section - Write clearer comments in Dockerfile; remove redundant comments - Remove redundant quickstart guide server files clean-up: anno_vs_anno_server.py, feat_vs_anno_server.py, nearest_neighbor_server.py, scatterplot_server.py ui files clean-up: anno_vs_anno_ui.py, annotations_ui.py, feat_vs_anno_ui.py, features_ui.py, scatterplot_ui.py
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 5, 2025
…AP#61 small fixes - Update environment.yml to make it consistent with requirement.txt - Update README.md to include TA's name docs clean-up - Update .gitignore to include Jupyter section - Write clearer comments in Dockerfile; remove redundant comments
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 5, 2025
…AP#61 small fixes - Update environment.yml to make it consistent with requirement.txt - Update README.md to include TA's name docs clean-up - Update .gitignore to include Jupyter section - Write clearer comments in Dockerfile; remove redundant comments
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 5, 2025
…AP#61 small fixes - Update environment.yml to make it consistent with requirement.txt - Update README.md to include TA's name docs clean-up - Update .gitignore to include Jupyter section - Write clearer comments in Dockerfile; remove redundant comments
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 6, 2025
…AP#61 small fixes - Update environment.yml to make it consistent with requirement.txt - Update README.md to include TA's name docs clean-up - Update .gitignore to include Jupyter section - Write clearer comments in Dockerfile; remove redundant comments
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 6, 2025
…AP#61 small fixes - Update environment.yml to make it consistent with requirement.txt - Update README.md to include TA's name docs clean-up - Update .gitignore to include Jupyter section - Write clearer comments in Dockerfile; remove redundant comments
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 7, 2025
…AP#61 small fixes - Update environment.yml to make it consistent with requirement.txt - Update README.md to include TA's name docs clean-up - Update .gitignore to include Jupyter section - Write clearer comments in Dockerfile; remove redundant comments
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 7, 2025
small fixes - Update environment.yml to make it consistent with requirement.txt - Update README.md to include TA's name docs clean-up - Update .gitignore to include Jupyter section - Write clearer comments in Dockerfile; remove redundant comments - Remove redundant quickstart guide server files clean-up: anno_vs_anno_server.py, feat_vs_anno_server.py, nearest_neighbor_server.py, scatterplot_server.py ui files clean-up: anno_vs_anno_ui.py, annotations_ui.py, feat_vs_anno_ui.py, features_ui.py, scatterplot_ui.py
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 7, 2025
small fixes - Update environment.yml to make it consistent with requirement.txt - Update README.md to include TA's name docs clean-up - Update .gitignore to include Jupyter section - Write clearer comments in Dockerfile; remove redundant comments - Remove redundant quickstart guide server files clean-up: anno_vs_anno_server.py, feat_vs_anno_server.py, nearest_neighbor_server.py, scatterplot_server.py ui files clean-up: anno_vs_anno_ui.py, annotations_ui.py, feat_vs_anno_ui.py, features_ui.py, scatterplot_ui.py
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 7, 2025
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 11, 2025
zhan4329
added a commit
to Saran-Nag/SPAC_Shiny-Purdue-2025
that referenced
this pull request
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request merges all six open PRs and introduces some other necessary changes. Here are the details.
New Features from Previous PRs
Code Refactoring
Dependency Management
requirements.txtto support the newly introduced heatmap mode in scatter plotenvironment.yml:requirement.txtDevelopment and Deployment Infrastructure
Dockerfile:.gitignoreto exclude an unnecessary Jupyter-related file formatDocumentation
README.mdto include names of this year's Data Mine Team contributors and TACONTRIBUTING.mdwith links to the copilot-based instructions as well as SPAC Package project's contributing guideRemarks About the Six Open PRs
environment.yml.Remarks About Other Changes
Dockerfile, especially the Python version. We haven't found any new issues though.