Skip to content

Feat vs Anno Tab Labels Readability Fix (ref. PR #51) #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
zhan4329 wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Feat vs Anno Tab Labels Readability Fix (ref. PR #51) #66

zhan4329 wants to merge 9 commits into from

Conversation

@zhan4329
Copy link
Contributor

@zhan4329 zhan4329 commented Nov 15, 2025 •
edited
Loading

Description

This Pull Request reformulates student contributions in #51. It adds several axis settings as well as refactors some codes for better ui experience on the 'Feat vs Anno' tab and code readability.

Related Issue/PR

This Pull Request rewrites #51
This Pull Request closes Saran-Nag#22

Changes

1. New Axis Settings for Better Label Readability

It implements the following new axis settings on 'Feat vs Anno' tab to solve label readability issue:

  • Adds an axis label font size slider
  • Adds an abbreviate toggle for label characters
  • Adds a Y-axis label rotator in addition to the current X-axis label rotator

2. UI Settings Change for 508 Compliance and Better UI Experience

It optimizes the following ui settings according to the ui style in 'Nearest Neighbor' tab to fulfill 508 compliance and provide better ui experience:

  • Control panel:
    • Splits the control panel into sections - Core Parameters, Plot Configuration, Figure Configuration, and Axis Settings as in 'Nearest Neighbor' tab
    • TODO: Changes sliders to numerical input (508 compliance)
  • Output figure:
    • Pre-set zoom settings for output figure to prevent it from exceeding borders
    • TODO: Adds the missing figure title (508 compliance)

3. Code Refactoring for Better Performance and Code Readability

It does the following necessary code refactoring according to the code style in 'Nearest Neighbor' tab for better performance and code readability:

  • Uses 'panel_conditional' instead of 'insert-delete' pattern for dendrogram checkbox
  • Uses 'hm1' for prefix instead of any previous existing prefixes for 'Feat vs Anno' tab
  • Relocates the adata generation process outside of the heatmap function for faster data generation and more modular writing style

Areas for Improvement

Changes are needed to make the tab meet the 508 compliance with ANDI

  • Changes sliders to numerical input (508 compliance)
  • Adds the missing figure title (508 compliance)

root and others added 7 commits November 11, 2025 19:05
@zhan4329
✨ Abbreviation toggle, font styling, and heatmap controls implemented
b1c1098
@zhan4329
Update feat_vs_anno_server.py with better readibality
4395ef9
@zhan4329
Update feat_vs_anno_server.py with better readability for the labels
1d6febc
@zhan4329
feat(ui): improve Feat. vs Anno. tab ui as in Nearest Neighbor tab
7c8b2d5
@zhan4329
fix(ui): Prevent labels to exceed borders in FvA tab
964492b
@zhan4329
refactor(fva): restructure feat vs anno tab ui/server logic
7e5be5e 
- move dendrogram checkbox from server to ui
- move abbreviation slider from server to ui
@zhan4329
chore(fva): update feat_vs_anno_server.py for better readability
6eb15d9 
- remove unused rendering state variable
- relocate variables to make the codes more modular (cmap, fontsize)
- rename fontsize as axis_fontsize for future implementation of figure_fontsize
- relocate adata generation process
@zhan4329 zhan4329 marked this pull request as ready for review November 15, 2025 02:52
@zhan4329 zhan4329 mentioned this pull request Nov 19, 2025
Open
@zhan4329 zhan4329 linked an issue Nov 20, 2025 that may be closed by this pull request
Feat vs Anno Tab Axis Label Adjustment Saran-Nag/SPAC_Shiny-Purdue-2025#22
Open
zhan4329
zhan4329 commented Dec 2, 2025
View reviewed changes
Copy link
Contributor Author

@zhan4329 zhan4329 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verifying that the updated code uses the same design for other visualization tabs:

  • how the shared data is read: logic does not change
  • the UI: same UI styling as in nearest_neighbor tab
  • the 508 compliance using ANDI

@zhan4329 zhan4329 closed this Dec 4, 2025
@zhan4329
Copy link
Contributor Author

zhan4329 commented Dec 4, 2025 •
edited
Loading

I will re-develop it.

@zhan4329 zhan4329 deleted the feat/feat-vs-anno-axis-22 branch December 4, 2025 20:20
@zhan4329 zhan4329 restored the feat/feat-vs-anno-axis-22 branch January 15, 2026 21:25
@zhan4329 zhan4329 reopened this Jan 15, 2026
@zhan4329 zhan4329 marked this pull request as draft January 15, 2026 21:40
@zhan4329 zhan4329 changed the title Reformulation of Student Contributions on 'Feat vs Anno' Tab UI Improvement on 'Feat vs Anno' Tab Jan 15, 2026
@zhan4329 zhan4329 changed the title UI Improvement on 'Feat vs Anno' Tab Feat vs Anno Tab Labels Readability Fix (Reformulation) Jan 15, 2026
@zhan4329 zhan4329 changed the title Feat vs Anno Tab Labels Readability Fix (Reformulation) Feat vs Anno Tab Labels Readability Fix (Reformulation of PR #51) Jan 15, 2026
@zhan4329 zhan4329 changed the title Feat vs Anno Tab Labels Readability Fix (Reformulation of PR #51) Feat vs Anno Tab Labels Readability Fix (ref. PR #51) Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feat vs Anno Tab Axis Label Adjustment

1 participant

@zhan4329