Make the V1 Reader Empty Value Aware#7
Open
calmilamsy wants to merge 5 commits intoFabricMC:masterfrom
Open
Conversation
|
bump |
Player3324
reviewed
Aug 28, 2022
| mapping.getOrCreateFieldMapping(field.getName(this.from), field.getDesc(this.from)) | ||
| .setDeobfuscatedName(field.getName(this.to)); | ||
| final String fieldNameTo = field.getName(this.to); | ||
| final String fieldNameFrom = field.getName(this.from); |
There was a problem hiding this comment.
I believe these "from" names can be null too? With custom namespaces they are not necessarily in the mandatory populated NS column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes errors related to the target name being empty, and should fix support for v1 mappings with empty values.
Continuation of FabricMC/tiny-remapper#85