-
Notifications
You must be signed in to change notification settings - Fork 2
feat: adds beds D-1 and D-2 to field D #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
feat: adds beds D-1 and D-2 to field D #69
Conversation
17d03cb to
a39a083
Compare
These changes look good. Tag me on this PR when you have had a chance to rebuild the sample database and add it to the PR. |
|
@braughtg I rebuilt the sample database and added it to this PR. I still need to fix three failing tests on the FarmData2 repository. |
Great. This looks good. I will pull and test it and then merge it if everything looks good. When you have the tests patched, make that PR to the FarmData2 upstream. |
braughtg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested this and everything looks good! Well done @alyssa-greenwell.
I will merge this when FarmData2/FarmData2#554 is complete.
Added beds D-1 and D-2 to field D and changed the transplanting of some of the Ghana Iceberg Lettuce into D-1 and D-2. These changes are made to close issue #553 in the FarmData2 repository. I edited the appropriate lines in areas.csv and transplantings.csv. However when I try to build the database I am asked for a sudo fd2dev password, which I do not have and cannot find in the documentation, so the changes are yet to be tested. I require some assistance from the maintainers to either get access to the fd2dev password or to help test the changes. However being able to test this on my own would be ideal as I want to work on issue #554 next, which would require these changes be implemented.
Closes FarmData2/FarmData2#553