Skip to content

Arbitrum/atlas v1.1 #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BenSparksCode wants to merge 129 commits into
base: arbitrum/atlas-v1.0
Choose a base branch
from
Open

Arbitrum/atlas v1.1 #445

BenSparksCode wants to merge 129 commits into from

Conversation

@BenSparksCode
Copy link
Contributor

@BenSparksCode BenSparksCode commented Oct 24, 2024 •
edited
Loading

Changes:

  • Brings Atlas v1.1 updates as detailed in feat: Atlas v1.1 #428 to our custom Arbitrum version of Atlas
  • Brings size cuts as detailed in refactor: contract size cuts #444 to our custom Arbitrum version of Atlas
  • Minor tweaks to Atlas and L2 Gas Calculator deploy scripts to be more generic across all chains
  • Detect if chain is Arbitrum Nova in the constructor of ArbitrumGasCalculator.

Atlas contract size is 24,424 bytes (152 bytes below limit) and is thus deployable on Arbitrum.

BenSparksCode and others added 30 commits September 4, 2024 17:28
@BenSparksCode
fix: conditionally forward returnData to solvers
a0dc8ff
@BenSparksCode
fix: enforce userOp.gas as userOp's gas limit
b46981c
@BenSparksCode
fix: use smaller of userOp.gas and gasleft() as limit
5e05707
@BenSparksCode
chore: update Atlas license
4c9c5e3
@BenSparksCode
chore: update Atlas license
a448c98
@jj1980a
base L2 gas calculator contract
cf271a6
@jj1980a
contract ownable
f5e9dd1
@jj1980a
introduce a customizable offset value to be added to passed call data…
f8dbebc 
… length
@jj1980a
deploy script
fd33c38
@jj1980a
forge update
2448be0
@thogard785
back-end approach
8fcf58f
@BenSparksCode
Merge pull request #421 from FastLane-Labs/license-fix
58fa483 
chore: update Atlas license
@BenSparksCode
Merge branch 'main' into atlas-v1.1
237be45
@BenSparksCode
Merge branch 'atlas-v1.1' into solver-surcharge-tracking
6da7e88
@BenSparksCode
fmt: forge fmt
47bcfd8
@BenSparksCode
fix: TrebleSwap tests to handle new surcharge rules
44eb8e0
@BenSparksCode
fix: record accurate solverSurcharge figure
392ba0e
@BenSparksCode
fix: 2 Escrow tests - metacall no longer reverts
0f749da
@BenSparksCode
fix: FLOnline breaking tests for surcharge rule change
6f1f469
@BenSparksCode
chore: Base L2 Gas Calculator deploy script tweaks
c4de266
@jj1980a @BenSparksCode
Apply suggestions from code review
20ac0af 
Co-authored-by: Ben Sparks <52714090+BenSparksCode@users.noreply.github.com>
@jj1980a
forge fmt
04493e7
@jj1980a
fix deploy script
bc6f32a
@BenSparksCode
feat: add easier way to control hook failure for tests
547588b
@BenSparksCode
test: add forwardReturnData config tests
5605e76
@BenSparksCode
test: use hookShouldRevert pattern in Escrow.t.sol
4aa7646
@BenSparksCode
chore: rel import paths in DAppControl and parents
6109348
@BenSparksCode
chore: switch to relative imports
39394d9
@BenSparksCode
chore: use relative imports in BaseTest
705e15e
@BenSparksCode
chore: use relative imports in TestAtlas
5a25060
BenSparksCode and others added 30 commits November 12, 2024 16:24
@BenSparksCode
feat: add surcharge settings to deploy script
4807453
@BenSparksCode
chore: deploy Atlas v1.1 on Polygon
60a70b3
@BenSparksCode
Merge pull request #452 from FastLane-Labs/surcharge-settings-deploy
e6b1718 
feat: add surcharge settings to deploy script
@BenSparksCode
Merge branch 'atlas-v1.1' into arbitrum/atlas-v1.1
5a7baa8
@jj1980a
add base sepolia deployment adresses
3d372be
@aanand1
feat: base deployment
c27bd76
@BenSparksCode
Merge pull request #454 from FastLane-Labs/base_deployment
ee19471 
feat: base deployment
@jj1980a
Merge branch 'atlas-v1.1' into base-sepolia-deployment
3eb1d58
@jj1980a
Merge pull request #453 from FastLane-Labs/base-sepolia-deployment
1b7df52 
feat: base sepolia deployment
@jj1980a
univ3 pools creation script
6af7d57
@jj1980a
adjust initial pool price
b1d23f1
@jj1980a
Merge pull request #455 from FastLane-Labs/univ3-pools-script
a4d5b88 
feat: univ3 pools script
@jj1980a
set gas refund beneficiary as metacall parameter
b212c99
@jj1980a
remove isSimulator local variable to be under stack too deep limit
da38ccb
@jj1980a
fix unit test
01d62fa
@jj1980a
add gas refund beneficiary unit tests
63250c3
@BenSparksCode
refactor: replace modifier with internal function
9c37789
@BenSparksCode
refactor: make event addr params indexed
1516ef8
@BenSparksCode
refactor: replace Transfer events with Mint and Burn
47f9c76
@BenSparksCode
chore: remove redundant overflow check
9a68aae
@BenSparksCode
refactor: do SafeCast inline to save size
7092834
@BenSparksCode
refactor: _handleErrors for size cuts
2ae3777
@BenSparksCode
Merge pull request #457 from FastLane-Labs/more-size-cuts
66c1881 
refactor: more size cuts
@jj1980a
Merge branch 'atlas-v1.1' into gas-refund-beneficiary
40d7ee9
@BenSparksCode
chore: make test names camelCase
67388e7
@BenSparksCode
refactor: resolve stack too deep, add back _isSim var
fcb02f3
@BenSparksCode
refactor: simplify gas beneficiary logic
fe2fb3d
@BenSparksCode
Merge pull request #458 from FastLane-Labs/simplify-gas-beneficiary
8127c01 
refactor: simplify gas beneficiary logic
@BenSparksCode
Merge pull request #456 from FastLane-Labs/gas-refund-beneficiary
0ff49cc 
feat: gas refund beneficiary
@BenSparksCode
Merge branch 'atlas-v1.1' into arbitrum/atlas-v1.1
7bac29b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thogard785 thogard785 thogard785 left review comments

@0x1NotMe 0x1NotMe 0x1NotMe approved these changes

@aanand1 aanand1 Awaiting requested review from aanand1

@jj1980a jj1980a Awaiting requested review from jj1980a

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@BenSparksCode @0x1NotMe @thogard785 @jj1980a @aanand1