fix: preserve /api/ prefix in proxy_pass#39
Conversation
The API registers all routes with /api/ prefix (e.g. /api/csrf-token, /api/games, /api/user). The trailing slash on proxy_pass was stripping the prefix, causing all API routes to return 404.
Summary of ChangesHello @Feikovandijk, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue where API routes were returning 404 errors due to an incorrect Nginx Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly fixes a bug in the nginx proxy configuration that was stripping the /api/ prefix from backend requests. The change is correct. I've also added a suggestion to improve the robustness of the API routing by handling requests made to /api without a trailing slash, which are currently not matched by the proxy configuration.
Addresses PR review comment: location /api matches both /api and /api/... requests, preventing 404s for edge-case API calls.
The API registers all routes with /api/ prefix (e.g. /api/csrf-token, /api/games, /api/user). The trailing slash on proxy_pass was stripping the prefix, causing all API routes to return 404.