make training kernels faster by using shared memory#15
Open
mahdizaferanchi wants to merge 3 commits intoFelix-Petersen:mainfrom
Open
make training kernels faster by using shared memory#15mahdizaferanchi wants to merge 3 commits intoFelix-Petersen:mainfrom
mahdizaferanchi wants to merge 3 commits intoFelix-Petersen:mainfrom
Conversation
… of bit count add __repr__ to PackBitsTensor
Owner
|
Thanks for the additions! These optimizations restructure the code quite a bit and require a constant which could depend on the GPU model. I saw you showed improvements for a P100, but before merging it, I want to test it myself on some other more recent and diverse GPU models. That being said, I very much appreciate the improvements, and I intend to do these tests and integrate the block-level shared memory for the next version release (probably later this year). |
Contributor
Author
|
That sounds great! Yes, I understand the decision to merge these changes isn't trivial. I'm glad my work could be helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used CUDA block-level shared memory to optimize training kernels.
Find tests and results here.