Skip to content

makefile build improvements #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryao-01 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

makefile build improvements #140

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a584b32
build improvmements add --load to docker and pass in LOCAL_BUILD
ryao-01 Aug 22, 2025
aa60223
Merge branch 'main' into buildimprovements
ryao-01 Aug 22, 2025
8c2f2ee
fix: only need LOCAL_BUILD for forest
ryao-01 Aug 22, 2025
7cbbe05
make forest accept LOCAL_BUILD arg and also add docker build --load
ryao-01 Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ TARGET_ARCH ?= $(shell uname -m | sed 's/x86_64/amd64/' | sed 's/aarch64/arm64/'
DOCKER_PLATFORM = linux/$(TARGET_ARCH)

# Simple build command that works with any architecture
BUILD_CMD = docker build
BUILD_CMD = docker build --load
LOCAL_BUILD ?= 1

.PHONY: show-drand-tag
show-drand-tag:
Expand All @@ -25,8 +26,7 @@ show-forest-commit:
.PHONY: build-forest
build-forest:
@echo "Building forest for $(TARGET_ARCH) architecture..."
@echo "Forest commit: $(forest_commit)"
$(BUILD_CMD) --build-arg GIT_COMMIT=$(forest_commit) -t forest:latest -f forest/Dockerfile forest
$(BUILD_CMD) --build-arg GIT_COMMIT=$(forest_commit) --build-arg LOCAL_BUILD=${LOCAL_BUILD} -t forest:latest -f forest/Dockerfile forest

.PHONY: build-drand
build-drand:
Expand Down Expand Up @@ -73,4 +73,4 @@ help:
@echo " cleanup - Clean up containers and run cleanup script"
@echo ""
@echo "Architecture control:"
@echo " make all - Build all services for current architecture"
@echo " make all - Build all services for current architecture"