Further improve performance#4
Open
FreezePhoenix wants to merge 11 commits intoFilipssh:multiOutputfrom
Open
Conversation
Improve performance in scenarios where a pair of terms must be used.
This is the first commit out of a two-part series that improves performance further. This PR caches gate results to avoid recomputing a significant amount of data, and significantly reduces the amount of memory used by consolidating values (terms stay in the term dictionary, and we only store their identifier).
This is the second commit out of a two-part series that improves performance further. This PR caches gate results to avoid recomputing a significant amount of data, and significantly reduces the amount of memory used by consolidating values (terms stay in the term dictionary, and we only store their identifier).
Author
|
A second set of changes have been made that fix a regression I accidentally caused (wire_lamps was not actually correct anymore). Additionally, we now print out ORs instead of ANDs, as while they are functionally equivalent, they are free since we are already computing OR for XOR, and this allows us to avoid computing extraneous terms. From my measurements on Edge, this took the runtime for the sample input |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR caches gate results to avoid recomputing a significant amount of data, and significantly reduces the amount of memory used by consolidating values (terms stay in the term dictionary, and we only store their identifier).