This repository was archived by the owner on Aug 20, 2025. It is now read-only.
Updated calls to RemoteConfig and RealtimeDatabase so the project now…#30
Open
patm1987 wants to merge 2 commits intoFirebaseExtended:masterfrom
Open
Updated calls to RemoteConfig and RealtimeDatabase so the project now…#30patm1987 wants to merge 2 commits intoFirebaseExtended:masterfrom
patm1987 wants to merge 2 commits intoFirebaseExtended:masterfrom
Conversation
… compiles RemoteConfig moved to RemoteConfigDeprecated instances of Firebase.Unity.Editor removed
chkuang-g
reviewed
Apr 6, 2021
| var targets = kv.Value; | ||
| foreach (var target in targets) { | ||
| var value = FirebaseRemoteConfig.GetValue(target.FullKeyString); | ||
| var value = FirebaseRemoteConfigDeprecated.GetValue(target.FullKeyString); |
There was a problem hiding this comment.
FirebaseRemoteConfig.DefaultInstance?
Scripts/FirebaseInitializer.cs
Outdated
| if (!fetching) { | ||
| #if UNITY_EDITOR | ||
| var settings = FirebaseRemoteConfig.Settings; | ||
| var settings = FirebaseRemoteConfigDeprecated.Settings; |
There was a problem hiding this comment.
FirebaseRemoteConfig.DefaultInstance.ConfigSettings?
Similar to those in below
Scripts/FirebaseInitializer.cs
Outdated
| Initialize(status => { | ||
| FirebaseRemoteConfig.SetDefaults(defaultValues); | ||
| FirebaseRemoteConfig.FetchAsync(TimeSpan.Zero).ContinueWith(task => { | ||
| FirebaseRemoteConfigDeprecated.SetDefaults(defaultValues); |
There was a problem hiding this comment.
Firebase.RemoteConfig.FirebaseRemoteConfig.DefaultInstance.SetDefaultAsync(defaults).ContinueWithOnMainThread( task => {
// check if it failed...
return Firebase.RemoteConfig.FirebaseRemoteConfig.DefaultInstance.FetchAndActivateAsync();
}).Unwrap().ContinueWithOnMainThread(task => {
fetching = false;
activateFetched = true;
CallActivateFetchedCallbacks();
});
In FirebaseInitializer, removed the fetching variable. It seemed to only matter if fetching was ever set to true, and it never was.
dzlier-gcp
approved these changes
Apr 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… compiles
RemoteConfig moved to RemoteConfigDeprecated
instances of Firebase.Unity.Editor removed