Feat.self demote warning #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalaM314
requested changes
Jan 20, 2026
Comment on lines
148
to
161
| if(player == sender && rank.level < sender.rank.level){ | ||
| Menu.confirmDangerous( | ||
| sender, | ||
| "[red] ARE YOU SURE YOU WANT TO SELF DEMOTE. THIS ACTION CANNOT BE UNDONE!") | ||
| .then( async () => { | ||
| await player.setRank(rank); | ||
| logAction(`${sender} demoted themselves to ${rank}`); | ||
| outputSuccess(f`You have set your own rank to ${rank}`); | ||
| }) | ||
| } else { | ||
| await player.setRank(rank); | ||
| logAction(`set rank to ${rank.name} for`, sender, player); | ||
| outputSuccess(f`Set rank of player ${player} to ${rank}`); | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if(player == sender && rank.level < sender.rank.level){ | |
| Menu.confirmDangerous( | |
| sender, | |
| "[red] ARE YOU SURE YOU WANT TO SELF DEMOTE. THIS ACTION CANNOT BE UNDONE!") | |
| .then( async () => { | |
| await player.setRank(rank); | |
| logAction(`${sender} demoted themselves to ${rank}`); | |
| outputSuccess(f`You have set your own rank to ${rank}`); | |
| }) | |
| } else { | |
| await player.setRank(rank); | |
| logAction(`set rank to ${rank.name} for`, sender, player); | |
| outputSuccess(f`Set rank of player ${player} to ${rank}`); | |
| } | |
| if(player == sender && rank.level < sender.rank.level) | |
| await Menu.confirmDangerous(sender, "[scarlet]Are you sure you want to self-demote? THIS ACTION CANNOT BE UNDONE!"); | |
| await player.setRank(rank); | |
| logAction(`set rank to ${rank.name} for`, sender, player); | |
| outputSuccess(f`Set rank of player ${player} to ${rank}`); |
BalaM314
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a simple warning for people deciding to self demote. Helps catch the goofs (raymax) before they goof up