Add Startpage support; refactor search extraction#41
Open
yoasif wants to merge 1 commit intoFivefold:masterfrom
Open
Add Startpage support; refactor search extraction#41yoasif wants to merge 1 commit intoFivefold:masterfrom
yoasif wants to merge 1 commit intoFivefold:masterfrom
Conversation
- Implemented Startpage detection and sidebar injection - Added automatic theme detection for Startpage "Air" and "Night" modes - Unified search term extraction to support both 'q' and 'query' params - Improved config loading to prevent data loss during updates
Fivefold
reviewed
Jan 25, 2026
Owner
Fivefold
left a comment
There was a problem hiding this comment.
Looks great! I really appreciate you taking the time to implement startpage support.
Also appreciate the improvements/fixes for the config loading and search term extraction. I can't test at the moment, so I just have a few questions before merging:
- Since I don't personally use startpage (but I assume you do), would you be willing to handle startpage-related fixes in the future, e.g. if startpage changes their html?
- Can you make two screenshots for light and dark modes on startpage, showing the injection box?
- Did you check the various permutations in theme settings (e.g. setting startpage's theme to light but injector theme to dark, setting injector theme to auto detect and startpage to system theme, changing the system theme to light and to dark)?
Here is a table for the various permutations, with startpage theme settings horizontally and injector theme settings vertically:
| System (Light) | System (Dark) | Light | Dark | |
|---|---|---|---|---|
| Auto | ||||
| Light | ||||
| Dark |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23