-
Notifications
You must be signed in to change notification settings - Fork 46
feat: show statistics of the job queueing system #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: F.N. Claessen <felix@seita.nl>
Documentation build overview
Show files changed (6 files in total): 📝 6 modified | ➕ 0 added | ➖ 0 deleted
|
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…quirement rather than capacity utilization (otherwise, we could never see ρ > 100%) Signed-off-by: F.N. Claessen <felix@seita.nl>
…erse order with respect to the help string Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…rage-waiting-time
Signed-off-by: F.N. Claessen <felix@seita.nl>
nhoening
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Seems to work well. Most comments are about usability.
| \b | ||
| Stats overall: | ||
| - ρ = average capacity requirement (consider scaling up the number of workers when close to or higher than 100%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to use these generic variable names (p, K, L)? They are not used on the Wikipedia page for Little's-law. (L is being used, but you are using it now for both workers and jobs, it seems jobs is the right one)
They appear to the user in the important line "Overall: [etc]".
We can call them "capacity utilised", "workers required" and "workers available"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good comment.
Lshould indeed be foremost defined in terms of number of jobs. I made the implicit assumption that our goal is zero waiting time, in which case it would also be equal to the workers required.rho(not p) is pretty standard in the literature.kwas wrong, the canonical variable name ism
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a PhD and still cannot recall "standard literature" variable names and their meaning, then apply them to this context. Do you expect all FlexMeasures hosts have Master's degrees?
Why the aversion to making this user-friendly? (adding a few words is much friendlier than requiring all first users to call --help).
Currently, these words might be "capacity utilised", "jobs in system" and "workers available".
… comes, and where to go for deeper understanding. Co-authored-by: Nicolas Höning <nicolas@seita.nl> Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Co-authored-by: Nicolas Höning <nicolas@seita.nl> Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Co-authored-by: Nicolas Höning <nicolas@seita.nl> Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…notes to generate a better estimate and a risk averse estimate of the capacity requirement Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
|
(I'll resolve the changelog conflicts soon.) |
…rage-waiting-time # Conflicts: # documentation/changelog.rst # documentation/cli/change_log.rst
nhoening
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for applying improvements, I only don't agree with one point.
| \b | ||
| Stats overall: | ||
| - ρ = average capacity requirement (consider scaling up the number of workers when close to or higher than 100%) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a PhD and still cannot recall "standard literature" variable names and their meaning, then apply them to this context. Do you expect all FlexMeasures hosts have Master's degrees?
Why the aversion to making this user-friendly? (adding a few words is much friendlier than requiring all first users to call --help).
Currently, these words might be "capacity utilised", "jobs in system" and "workers available".
Co-authored-by: Nicolas Höning <nicolas@seita.nl> Signed-off-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
Description
flexmeasures jobs statsdocumentation/changelog.rstdocumentation/cli/change_log.rstLook & Feel
How to test
Run
flexmeasures jobs stats(preferably with an operational redis DB in yourflexmeasures.cfgsettings).Further Improvements