Skip to content

Change ORM for proper using of Dependency Injection #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Anisimova2020 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change ORM for proper using of Dependency Injection #23

Anisimova2020 wants to merge 2 commits into from

Conversation

@Anisimova2020
Copy link

@Anisimova2020 Anisimova2020 commented Mar 15, 2023

kuzkok
kuzkok reviewed Mar 15, 2023
View reviewed changes
text/0000-proper-DI.md

## Детальное проектирование

Ранее велись работы в этом направлении, которые учитываются при написании данной постановки:
Copy link
Member

@kuzkok kuzkok Mar 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ещё вот такое было #16

Copy link
Author

@Anisimova2020 Anisimova2020 Mar 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо, дополню.

@Anisimova2020 Anisimova2020 mentioned this pull request Mar 24, 2023
Open
NicholasNoise
NicholasNoise reviewed Mar 24, 2023
View reviewed changes
text/0000-proper-DI.md

Сейчас существует ряд особенностей ORM и ODataService, которые не позволяют использовать DI в "классическом виде".
1. Обращение к UnityFactory происходит в произвольном методе произвольного класса.
2. Аналогично происходит работа некоторых статических классов, которые фактически являются реализацией внедрения зависимостей (например, [DataServiceProvider.DataService](https://github.com/Flexberry/NewPlatform.Flexberry.ORM/blob/3ec3dc517469e6df519035d750a3da6c44a91bac/ICSSoft.STORMNET.Business/DataServiceProvider.cs#L28)).
Copy link

@NicholasNoise NicholasNoise Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пожалуй, самым проблемным является AuditService.Current

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kuzkok kuzkok kuzkok left review comments

@NicholasNoise NicholasNoise NicholasNoise left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Anisimova2020 @kuzkok @NicholasNoise