Add FlightCategory enumeration for flight types (Issue #18) #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Defines an enumeration for flight categories used in the Flightradar24 SDK.
DamianS21
reviewed
Nov 19, 2025
Member
DamianS21
left a comment
DamianS21
left a comment
There was a problem hiding this comment.
Thank you. Looks good.
Although to make it even better I suggest to add the new class to Position method resource e.g.
- https://github.com/Flightradar24/fr24api-sdk-python/blob/main/src/fr24sdk/resources/live/positions.py
- https://github.com/Flightradar24/fr24api-sdk-python/blob/main/src/fr24sdk/resources/historic/positions.py
For example:
categories: Optional[list[Union[FlightCategory, str]]] = None
This is similar to how AltitudeRange is currently handled and would allow IDEs to provide better autocompletion for the available categories while maintaining backward compatibility with strings.
DamianS21
added a commit
that referenced
this pull request
Nov 25, 2025
* Add FlightCategory enumeration for flight types Defines an enumeration for flight categories used in the Flightradar24 SDK. * Update __init__.py * Supersedes #19 --------- Co-authored-by: harikcecaps4-max <harikcecaps4@gmail.com>
Member
|
Thank you again for the changes. It has been continued and merged in #21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements issue #18 by adding a FlightCategory enumeration to the SDK.
Changes
flight_category.pywith theFlightCategoryenum class__init__.pyto export FlightCategoryDetails
The FlightCategory enum maps character literals used by the FR24 API to identify different types of aircraft and flight operations:
Fixes #18