#5928 Fix secure reply-all issues in Gmail context menu#5934
#5928 Fix secure reply-all issues in Gmail context menu#5934
Conversation
|
Hi @martgil, in this PR the only thing left is to fix failing tests or some additional code fixes are needed too? |
|
Hello @sosnovsky its all good but the tests keep failing. ill rerun the tests when i got home. |
|
Hi @martgil, tests not pass because of failing |
|
Sometimes, the test |
|
I can now confirm that |
|
It seems |
|
@sosnovsky - The test just started to work fine in the current test. The other test that fails so often is I'll let it finish and if not, then I'll create the non-live test PR for it to be merged. |
|
@sosnovsky - would you like to enable auto-merge on this PR? |
|
Yes, it seems to work well and fix all reported issues, can be merged once tests are passing. |
|
Let's move on with the new PR @sosnovsky - tests are failing quite too often? Or maybe, a non-live test PR will do? |
I think it mostly happens with live tests, as mock tests usually pass without fails |
|
@sosnovsky This one is ready for a review. Thanks! |
This PR Fixes FlowCrypt secure reply invocation wrongly defaults to "reply" when accessed in Gmail's context menu.
close #5928
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):