#5947 Add info modal for key with newer expiry than existing key#5951
Merged
#5947 Add info modal for key with newer expiry than existing key#5951
Conversation
Collaborator
Author
|
wip: currently adding ui test |
added 6 commits
March 17, 2025 14:43
…-newer-key-version-upon-key-import
…-newer-key-version-upon-key-import
…-newer-key-version-upon-key-import
Collaborator
Author
|
Hi @sosnovsky - This one is ready for a review. Thank you! |
sosnovsky
reviewed
Mar 23, 2025
Collaborator
Author
|
Hi again @sosnovsky could you please kindly re-check this PR? thanks. |
sosnovsky
approved these changes
Mar 26, 2025
Collaborator
sosnovsky
left a comment
sosnovsky
left a comment
There was a problem hiding this comment.
Works great now, redirect to update key page is much more convenient 👍
sosnovsky
deleted the
issue-5947-detected-newer-key-version-upon-key-import
branch
Collaborator
Author
|
Thanks for your recommendation and for making it possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check to determine if the user is importing a private key with a newer expiry date than the existing one and notifies the user accordingly.
close #5947
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):