#5979 Better detection for emails with noname attachments

[martgil]

This PR add an in-between detection before concluding that the detected noname file is a possible encryptedMsg.

close #5979

---

Tests (delete all except exactly one):

• Tests added or updated

---

To be filled by reviewers

I have reviewed that this PR... (tick whichever items you personally focused on during this review):

• addresses the issue it closes (if any)
• code is readable and understandable
• is accompanied with tests, or tests are not needed
• is free of vulnerabilities
• is documented clearly and usefully, or doesn't need documentation

[martgil]

We'd normally, wrote test for such PR but for such case, its a customer email and I cannot wrote such that specific test email with a "noname" file that has "application/pdf" type.

I think the most feasible and right way to do this is by splitting the test decrypt - an ambiguous file "noname" should not be recognized as an encrypted message and should be hidden in encrypted message into two, as the newer change should also fit for email const threadId1 = '18adb91ebf3ba7b9'; // email attachment "noname" with type img/<image-extension> and I believe it would not be part of that tests.

[martgil]

Hi @sosnovsky - this one is ready for a review. Thank you.

[sosnovsky]

We'd normally, wrote test for such PR but for such case, its a customer email and I cannot wrote such that specific test email with a "noname" file that has "application/pdf" type.

It'll be useful to have such test, so in the future we won't break correct noname attachments parsing.
It should be possible to create such message with noname .pdf attachment by using Header Tools Lite extension for Thunderbird, it allows to edit message headers before sending.
Can you please try to create such message for test by removing name property from sending attachment?

[martgil]

Hi @sosnovsky, I tried your suggestion and it works flawlessly by using https://addons.thunderbird.net/en-US/thunderbird/addon/header-tools-lite/?src=search. This tool definitely helps a lot.

[martgil]

Hello @sosnovsky, I've added a test by crafting one. Please let me know if this looks good to you.

[sosnovsky]

all good now, thanks!