Conversation
Collaborator
Author
|
@sosnovsky Could you update assignes as per priority? I'm currently working on #5945 though |
sosnovsky
reviewed
Aug 4, 2025
| let db: IDBDatabase; | ||
| let storage: GlobalStoreDict; | ||
| const inMemoryStore = new ExpirationCache<string>('in_memory_store', 4 * 60 * 60 * 1000); // 4 hours | ||
| await BrowserMsg.guardAlarmFlood(); |
Collaborator
There was a problem hiding this comment.
what about just doing await chrome.alarms.clearAll() here? (without checking for alarms count in separate function)
I think reported case happens only for users who previously had more than 500 alarms when we were using random values in alarm names. this way we'll just remove all these unneeded alarms, and similar errors won't appear in the future.
Collaborator
Author
There was a problem hiding this comment.
Agreed—this is simpler, as there are no saved critical alarms impacting current functionality.
sosnovsky
deleted the
6051-error-an-extension-cannot-have-more-than-500-active-alarms
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixed alarm limit issue and service worker window issue
close #6051 // if this PR closes an issue
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):