Conversation
# Conflicts: # package-lock.json
…t/flowcrypt-browser into 6111-fix-secure-reply-live-test
|
@sosnovsky Fixed all issues(secure reply buttons view not replaced issue, secure buttons not inserted at top convo buttons issue, secure buttons not inserted at message menu issue) |
|
Well done, @ioanatflowcrypt! Please work on remaining tests fixes - some of them should probably already pass as you've fixed broken functionality. |
|
@ioanatflowcrypt font of secure options is different from plain Gmail actions, probably need to change css class for them:
|
…t/flowcrypt-browser into 6111-fix-secure-reply-live-test
…FlowCrypt/flowcrypt-browser into 6111-fix-secure-reply-live-test
|
@ioanatflowcrypt secure reply buttons look great now, just need to increase it's height to be the same as plain reply buttons: |
|
@sosnovsky Fixed all issues. Please check |
|
@ioanatflowcrypt works perfectly now, great job, thanks! |
|
Merged |
|
@sosnovsky I think we should publish a release for this fix, otherwise current extension users won’t be able to use the secure reply functions. |
|
Yes, I plan to upload new build to Chrome Web Store this week |
|
Sounds good 👍 |



This PR fixed secure reply buttons inject issue (due to gmail dom update) and fixed live tests
close #6111
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):