Merged
Conversation
Collaborator
Author
|
Hi @ioanatflowcrypt, @martgil, can you please approve this PR as it fixes issue which breaks FlowCrypt extension in Chrome 144 (it's public release is scheduled on the next week, so we should release update on this week): |
Collaborator
|
Hmmm... Checked PR but still same in my side. |
Collaborator
Author
|
@ioanatflowcrypt thanks for checking! looks like I initially tested with removed Firefox-specific code. I pushed fix which removes this Firefox check, as updated code works well in Firefox too. please re-check on your side |
ioanatflowcrypt
approved these changes
Jan 5, 2026
Collaborator
ioanatflowcrypt
left a comment
There was a problem hiding this comment.
Works great. Thank you👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR fixes
isServiceWorkercheck, to make it work correctly in the upcoming Chrome 144 releaseclose #6141
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):