ci: exclude META-INF/services file for VaadinServiceInitListener

[javier-godoy]

Close #161

Summary by CodeRabbit

• Chores
  • Optimized build packaging configuration for improved application assembly.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Modified the demo-jar Maven packaging configuration to exclude the VaadinServiceInitListener from the META-INF/services directory path, preventing service-provider resolution errors when integration test classes are not included in the packaged JAR.

Changes

Cohort / File(s)	Summary
Maven Build Configuration pom.xml	Added exclusion rule to demo-jar packaging to prevent VaadinServiceInitListener from META-INF/services being included when integration test provider classes are excluded

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• test: make tests compatible with Vaadin 25 #160: Directly related as it manages the VaadinServiceInitListener service-provider registration that this packaging exclusion rule addresses.

Suggested reviewers

• paodb
• mlopezFC

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: excluding a META-INF/services file for VaadinServiceInitListener in the packaging configuration.
Linked Issues check	✅ Passed	The code change directly addresses the root cause of issue #161 by excluding the VaadinServiceInitListener services file from the demo-jar packaging when the implementing class is not included.
Out of Scope Changes check	✅ Passed	The changes are limited to pom.xml packaging configuration and are directly scoped to resolving the linked issue without introducing unrelated modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b990af6 and 92bec6d.

📒 Files selected for processing (1)

• pom.xml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build-vaadin24

🔇 Additional comments (1)

pom.xml (1)

516-516: Exclusion directly addresses the root cause of issue #161.

The services file at src/test/resources/META-INF/services/com.vaadin.flow.server.VaadinServiceInitListener contains only a single entry referencing ViewInitializerImpl from the integration tests package, which is already excluded from the demo JAR. Excluding this services file prevents the ServiceConfigurationError at startup when the referenced provider class is not available.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud