-
Notifications
You must be signed in to change notification settings - Fork 9
ci: update workflow for new major version #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe PR introduces a new GitHub Actions workflow ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/maven-v3.yml:
- Line 23: The workflow is pinning actions/setup-java@v3 (used in the steps with
"uses: actions/setup-java@v3"); update each occurrence to actions/setup-java@v4
to avoid the deprecated Node 16 runtime. Locate the three "uses:
actions/setup-java@v3" entries (the ones at the job step lines shown in the
diff) and replace the version suffix from @v3 to @v4, keeping any existing
inputs (e.g., java-version) unchanged so the step behavior remains the same.
- Line 29: The workflow is invoking non-existent Maven profiles -Pv23 and -Pv24
and uses Java 8 while the project defines only a v25 profile and requires Java
17; either add v23 and v24 profiles to pom.xml to build Vaadin 23/24, or update
the workflow to use the existing profile (e.g., change -Pv23/-Pv24 to -Pv25 or
remove the profile flag) and set the actions/setup-java step to Java 17, and
update the job name/labels that incorrectly reference Vaadin 14 to reflect the
actual Vaadin version used.
🧹 Nitpick comments (1)
.github/workflows/maven-v3.yml (1)
17-55: Consider using a matrix strategy to reduce duplication.The three jobs follow an identical pattern with only JDK version and Maven profile varying. A matrix strategy would consolidate these into a single job definition, improving maintainability.
♻️ Proposed refactor using matrix strategy
jobs: - build-vaadin14: + build: runs-on: ubuntu-latest + strategy: + matrix: + include: + - vaadin-version: '14' + java-version: '8' + profile: '' + - vaadin-version: '23' + java-version: '11' + profile: '-Pv23' + - vaadin-version: '24' + java-version: '17' + profile: '-Pv24' steps: - uses: actions/checkout@v4 - name: Set up JDK - uses: actions/setup-java@v3 + uses: actions/setup-java@v4 with: - java-version: '8' + java-version: ${{ matrix.java-version }} distribution: 'temurin' cache: maven - - name: Build (Vaadin 14) - run: mvn -B package --file pom.xml - - build-vaadin23: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - name: Set up JDK - uses: actions/setup-java@v3 - with: - java-version: '11' - distribution: 'temurin' - cache: maven - - name: Build (Vaadin 23) - run: mvn -B package --file pom.xml -Pv23 - - build-vaadin24: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 - - name: Set up JDK - uses: actions/setup-java@v3 - with: - java-version: '17' - distribution: 'temurin' - cache: maven - - name: Build (Vaadin 24) - run: mvn -B package --file pom.xml -Pv24 + - name: Build (Vaadin ${{ matrix.vaadin-version }}) + run: mvn -B package --file pom.xml ${{ matrix.profile }}
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/maven-v3.yml.github/workflows/maven.yml
💤 Files with no reviewable changes (1)
- .github/workflows/maven.yml
🧰 Additional context used
🪛 actionlint (1.7.10)
.github/workflows/maven-v3.yml
23-23: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
36-36: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
49-49: the runner of "actions/setup-java@v3" action is too old to run on GitHub Actions. update the action's version to fix this issue
(action)
🔇 Additional comments (1)
.github/workflows/maven-v3.yml (1)
1-16: LGTM! Workflow configuration is appropriate.The workflow name and trigger configuration for the v3.x branch are correctly defined.



Summary by CodeRabbit
Release Notes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.