Open
Conversation
2. Fix some issues with 21000.StateReport.uavcan 3. Add a 21001.DirectOverride.uavcan file
There was a problem hiding this comment.
Pull request overview
Adds a new Flytrex DelCon (delivery controller) DroneCAN/UAVCAN DSDL namespace for reporting controller state and sending configuration/override commands, plus a small CI maintenance update.
Changes:
- Introduce new DelCon DSDL message definitions:
StateReport,DirectOverride,ParamSet,DesignConstantsSet. - Update the regression workflow to use
actions/checkout@v4andactions/upload-artifact@v4.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| flytrex/delcon/21000.StateReport.uavcan | New DelCon state-report message with mode/state flags and spool internal/output telemetry. |
| flytrex/delcon/21001.DirectOverride.uavcan | New DelCon direct-override message for commanding controller inputs/states. |
| flytrex/delcon/21002.ParamSet.uavcan | New DelCon parameter-set command message for storing/recalling/executing ParamSet configurations. |
| flytrex/delcon/21003.DesignConstantsSet.uavcan | New DelCon design-constants set message for storing/recalling mechanical constants. |
| .github/workflows/test_regression.yml | Bump GitHub Actions used by CI to v4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2. Change the type of spool_input_req_shaft_ctrl_load from float16 to bool 3. Add a few comments to the relevant DSDL files 4. Rename max_torque to max_torque_Nm
…float32
2. Change all the float16 field types in 21003.DesignConstantsSet.uavcan to float32
3. Add 2 new DSDL files:
- 21010.WriteConfigFile.uavcan
- 21011.ReadConfigFile.uavcan
- Path.uavcan
2. Add new messages: ParamSet, DesignConstantsSet, WriteConfigFile & ReadConfigFile
…ulated_data_types into feature/SupportDelCon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.