tests for classes containing setters with custom logic#1102
Open
xeniorn wants to merge 4 commits intoFody:masterfrom
Open
tests for classes containing setters with custom logic#1102xeniorn wants to merge 4 commits intoFody:masterfrom
xeniorn wants to merge 4 commits intoFody:masterfrom
Conversation
…tom code side effects (before or after value assignment)
…ing setter logic with tests
…nally disable failing test case for the missing implementation based on compilation flag, turned off by default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for a use case not covered by existing tests - setter with preexisting custom logic.
Add configurability for the new behavior, with default being the old behavior.
The solution
Todos
Unintended side effects of weaver on setters with custom logic #1101