fixup! [OU-ADD] account #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
hbrunn
commented
May 5, 2025
|
|
||
|
|
||
| def convert_company_dependent(env): | ||
| openupgrade_180.convert_company_dependent(env, "account.account", "code_store") |
Author
There was a problem hiding this comment.
it wasn't a property before, we need to create our own property field
hbrunn
commented
May 5, 2025
| SET sending_data = jsonb_set(sending_data::jsonb - 'mail_template_id', | ||
| '{{mail_template}}', {mail_template}) | ||
| WHERE id = {move_id}""", | ||
| ) |
Author
There was a problem hiding this comment.
the sending_data field is only used for the batch wizard, and there the mail template can't be set at all.
See the test data file that actually fills this field for the test migration, the above code fails there because this is an id in v17
MiquelRForgeFlow
merged commit 6cba94d
into
ForgeFlow:18.0-mig-account
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.