Skip to content

Conversation

@hbrunn
Copy link

@hbrunn hbrunn commented Jun 9, 2025

I think it's helpful to first fix the desired behavior post migration, and then look into how to achieve this. I've added a couple of tests here that fail, let's take it from there.

My suggestion would be:

  • copy location_dest_id to location_final_id
  • set location_dest_from_rule for all pull rules
  • for done moves created by push rules, set location_final_id to last location_dst_id

@MiquelRForgeFlow
Copy link

Selection_4581

@hbrunn
Copy link
Author

hbrunn commented Jun 10, 2025

that's expected, these tests are assertions how the migration should behave in my opinion, not how it currently behaves. see todos in the test code

Copy link

@MiquelRForgeFlow MiquelRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I hope your tests are correct, if not it will be a mess.

@MiquelRForgeFlow MiquelRForgeFlow merged commit 7f93189 into ForgeFlow:18.0-fix-stock Jun 10, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants