Skip to content

Conversation

@ryanbas21
Copy link
Collaborator

@ryanbas21 ryanbas21 commented Dec 10, 2025

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@forgerock/davinci-client@2.0.0

Major Changes

Patch Changes

  • #504 7834cde Thanks @ancheetah! - Improve FIDO module error handling when no options

  • Updated dependencies [9ad4062]:

    • @forgerock/sdk-logger@2.0.0
    • @forgerock/sdk-oidc@2.0.0
    • @forgerock/sdk-request-middleware@2.0.0
    • @forgerock/storage@2.0.0
    • @forgerock/sdk-types@2.0.0

@forgerock/device-client@2.0.0

Major Changes

@forgerock/journey-client@2.0.0

Major Changes

Patch Changes

  • #500 e99b374 Thanks @ancheetah! - Add support for KBA allowUserDefinedQuestions flag

  • Updated dependencies [9ad4062]:

    • @forgerock/sdk-logger@2.0.0
    • @forgerock/sdk-request-middleware@2.0.0
    • @forgerock/storage@2.0.0
    • @forgerock/sdk-types@2.0.0
    • @forgerock/sdk-utilities@2.0.0

@forgerock/oidc-client@2.0.0

Major Changes

Patch Changes

  • Updated dependencies [9ad4062]:
    • @forgerock/iframe-manager@2.0.0
    • @forgerock/sdk-logger@2.0.0
    • @forgerock/sdk-oidc@2.0.0
    • @forgerock/sdk-request-middleware@2.0.0
    • @forgerock/storage@2.0.0
    • @forgerock/sdk-types@2.0.0

@forgerock/protect@2.0.0

Major Changes

@forgerock/iframe-manager@2.0.0

Major Changes

@forgerock/sdk-logger@2.0.0

Major Changes

@forgerock/sdk-oidc@2.0.0

Major Changes

Patch Changes

  • Updated dependencies [9ad4062]:
    • @forgerock/sdk-types@2.0.0
    • @forgerock/sdk-utilities@2.0.0

@forgerock/sdk-request-middleware@2.0.0

Major Changes

@forgerock/storage@2.0.0

Major Changes

Patch Changes

  • Updated dependencies [9ad4062]:
    • @forgerock/sdk-types@2.0.0

@forgerock/sdk-types@2.0.0

Major Changes

@forgerock/sdk-utilities@2.0.0

Major Changes

Summary by CodeRabbit

  • Chores
    • Released major version 2.0.0 across multiple packages in the SDK suite, including journey-client, davinci-client, oidc-client, protect, and supporting libraries.
    • Updated package versions and synchronized dependencies across the ecosystem.
    • Updated changelog documentation for version 2.0.0 releases.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Dec 10, 2025

📝 Walkthrough

Walkthrough

Bumps many package versions from 1.3.0 (and 0.0.1 for device-client) to 2.0.0, adds top-level 2.0.0 entries to multiple CHANGELOGs, and deletes .changeset/eleven-baboons-battle.md. No source code or API changes detected.

Changes

Cohort / File(s) Summary
Changeset removal
.changeset/eleven-baboons-battle.md
Deleted a changeset entry that documented KBA allowUserDefinedQuestions flag support.
Clients & product packages
packages/davinci-client/package.json, packages/davinci-client/CHANGELOG.md, packages/journey-client/package.json, packages/journey-client/CHANGELOG.md, packages/oidc-client/package.json, packages/oidc-client/CHANGELOG.md, packages/protect/package.json, packages/protect/CHANGELOG.md, packages/device-client/package.json, packages/device-client/CHANGELOG.md
version fields bumped (mostly 1.3.02.0.0, device-client 0.0.12.0.0); new ## 2.0.0 changelog sections added. No code or API changes.
SDK effects packages
packages/sdk-effects/iframe-manager/package.json, packages/sdk-effects/iframe-manager/CHANGELOG.md, packages/sdk-effects/logger/package.json, packages/sdk-effects/logger/CHANGELOG.md, packages/sdk-effects/oidc/package.json, packages/sdk-effects/oidc/CHANGELOG.md, packages/sdk-effects/sdk-request-middleware/package.json, packages/sdk-effects/sdk-request-middleware/CHANGELOG.md, packages/sdk-effects/storage/package.json, packages/sdk-effects/storage/CHANGELOG.md
Version bumps to 2.0.0 and added 2.0.0 changelog entries (PR references, dependency notes). No functional changes.
SDK foundation packages
packages/sdk-types/package.json, packages/sdk-types/CHANGELOG.md, packages/sdk-utilities/package.json, packages/sdk-utilities/CHANGELOG.md
Version bumps to 2.0.0 and added 2.0.0 changelog entries. Public APIs unchanged.
Misc manifest updates (summary)
packages/.../package.json (multiple listed above)
All affected package.json files had only version updated to 2.0.0 (or device-client to 2.0.0); no other manifest fields altered.

Sequence Diagram(s)

(omitted)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • cerebrl

Poem

🐇 I hopped through files with gentle paws,

Bumped each version and fixed the changelog laws.
One tiny changeset I nudged away,
Now packages sparkle for release day.
🥕 Hooray from the rabbit — hip hip hooray!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Release PR' is vague and generic, lacking specific information about the version bump or packages being released. Use a more descriptive title such as 'Release: Bump all packages to version 2.0.0' or 'Release v2.0.0 of ping-javascript-sdk packages' to clearly communicate the purpose.
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed The description is comprehensive and well-structured, containing detailed release notes with package versions, major/patch changes, and dependency updates as auto-generated by Changesets action.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2361b54 and efc6acb.

📒 Files selected for processing (26)
  • .changeset/eleven-baboons-battle.md
  • .changeset/hip-owls-rule.md
  • packages/davinci-client/CHANGELOG.md
  • packages/davinci-client/package.json
  • packages/device-client/CHANGELOG.md
  • packages/device-client/package.json
  • packages/journey-client/CHANGELOG.md
  • packages/journey-client/package.json
  • packages/oidc-client/CHANGELOG.md
  • packages/oidc-client/package.json
  • packages/protect/CHANGELOG.md
  • packages/protect/package.json
  • packages/sdk-effects/iframe-manager/CHANGELOG.md
  • packages/sdk-effects/iframe-manager/package.json
  • packages/sdk-effects/logger/CHANGELOG.md
  • packages/sdk-effects/logger/package.json
  • packages/sdk-effects/oidc/CHANGELOG.md
  • packages/sdk-effects/oidc/package.json
  • packages/sdk-effects/sdk-request-middleware/CHANGELOG.md
  • packages/sdk-effects/sdk-request-middleware/package.json
  • packages/sdk-effects/storage/CHANGELOG.md
  • packages/sdk-effects/storage/package.json
  • packages/sdk-types/CHANGELOG.md
  • packages/sdk-types/package.json
  • packages/sdk-utilities/CHANGELOG.md
  • packages/sdk-utilities/package.json
💤 Files with no reviewable changes (2)
  • .changeset/eleven-baboons-battle.md
  • .changeset/hip-owls-rule.md
✅ Files skipped from review due to trivial changes (3)
  • packages/sdk-effects/iframe-manager/CHANGELOG.md
  • packages/sdk-types/CHANGELOG.md
  • packages/sdk-utilities/package.json
🚧 Files skipped from review as they are similar to previous changes (13)
  • packages/protect/CHANGELOG.md
  • packages/sdk-effects/iframe-manager/package.json
  • packages/protect/package.json
  • packages/oidc-client/CHANGELOG.md
  • packages/sdk-types/package.json
  • packages/sdk-effects/storage/package.json
  • packages/sdk-effects/sdk-request-middleware/package.json
  • packages/device-client/CHANGELOG.md
  • packages/journey-client/package.json
  • packages/device-client/package.json
  • packages/sdk-effects/logger/package.json
  • packages/oidc-client/package.json
  • packages/sdk-effects/oidc/CHANGELOG.md
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-09-23T20:50:26.537Z
Learnt from: ancheetah
Repo: ForgeRock/ping-javascript-sdk PR: 417
File: packages/sdk-effects/storage/src/lib/storage.effects.ts:11-12
Timestamp: 2025-09-23T20:50:26.537Z
Learning: When the storage client API was changed from returning void to GenericError | null in SDKS-4361, call sites in DaVinci client and OIDC client were not updated to handle the returned errors, creating a follow-up task for proper error handling implementation.

Applied to files:

  • packages/davinci-client/CHANGELOG.md
📚 Learning: 2025-10-22T15:14:00.044Z
Learnt from: ryanbas21
Repo: ForgeRock/ping-javascript-sdk PR: 430
File: packages/journey-client/src/lib/callbacks/name-callback.ts:9-15
Timestamp: 2025-10-22T15:14:00.044Z
Learning: In packages/journey-client, callback classes are internal implementation details not part of the public API. The callbacks barrel (src/lib/callbacks/index.ts) intentionally only exports the base JourneyCallback class. Internal code imports concrete callback classes directly from their individual files (e.g., factory.ts, journey-client.ts).

Applied to files:

  • packages/journey-client/CHANGELOG.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: pr
🔇 Additional comments (8)
packages/sdk-effects/oidc/package.json (1)

3-3: LGTM!

Version bump to 2.0.0 is consistent with the coordinated major release across the SDK packages.

packages/davinci-client/package.json (1)

3-3: LGTM!

Version bump to 2.0.0 aligns with the coordinated major release. The workspace:* references for internal dependencies will be correctly resolved during publish.

packages/sdk-effects/logger/CHANGELOG.md (1)

3-7: LGTM!

Changelog entry for 2.0.0 follows standard Changesets format with proper PR and commit references.

packages/sdk-utilities/CHANGELOG.md (1)

3-7: LGTM!

Changelog entry is consistent with the coordinated 2.0.0 release across the SDK packages.

packages/davinci-client/CHANGELOG.md (1)

3-18: LGTM!

Comprehensive changelog entry documenting the major version bump, the FIDO error handling patch (PR #504), and all updated internal dependencies at 2.0.0.

packages/journey-client/CHANGELOG.md (1)

3-19: LGTM! Changelog entry is well-formatted.

The 2.0.0 changelog entry follows standard conventions with proper references to PRs and commits, includes both major and patch changes, and documents dependency updates correctly.

packages/sdk-effects/sdk-request-middleware/CHANGELOG.md (1)

3-8: LGTM! Clean and consistent changelog entry.

The 2.0.0 entry is properly formatted with the major version release reference.

packages/sdk-effects/storage/CHANGELOG.md (1)

3-13: LGTM! Complete changelog entry with proper dependency updates.

The 2.0.0 entry correctly documents the major release and includes the dependency update to @forgerock/sdk-types@2.0.0.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nx-cloud
Copy link
Contributor

nx-cloud bot commented Dec 10, 2025

View your CI Pipeline Execution ↗ for commit efc6acb

Command Status Duration Result
nx run-many -t build --no-agents ✅ Succeeded <1s View ↗
nx affected -t build lint test e2e-ci ✅ Succeeded 1m 57s View ↗

☁️ Nx Cloud last updated this comment at 2026-01-12 20:25:26 UTC

nx-cloud[bot]

This comment was marked as outdated.

@ryanbas21 ryanbas21 force-pushed the changeset-release/main branch from 8753b12 to d58c175 Compare December 10, 2025 21:46
Copy link
Contributor

@nx-cloud nx-cloud bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we reran your CI automatically.

Nx Cloud View detailed reasoning in Nx Cloud ↗


🎓 Learn more about Self-Healing CI on nx.dev

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 10, 2025

Open in StackBlitz

@forgerock/davinci-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/davinci-client@506

@forgerock/device-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/device-client@506

@forgerock/journey-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/journey-client@506

@forgerock/oidc-client

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/oidc-client@506

@forgerock/protect

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/protect@506

@forgerock/sdk-types

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-types@506

@forgerock/sdk-utilities

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-utilities@506

@forgerock/iframe-manager

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/iframe-manager@506

@forgerock/sdk-logger

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-logger@506

@forgerock/sdk-oidc

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-oidc@506

@forgerock/sdk-request-middleware

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/sdk-request-middleware@506

@forgerock/storage

pnpm add https://pkg.pr.new/ForgeRock/ping-javascript-sdk/@forgerock/storage@506

commit: efc6acb

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 18.80%. Comparing base (b89ad58) to head (efc6acb).
⚠️ Report is 22 commits behind head on main.

❌ Your project status has failed because the head coverage (18.80%) is below the target coverage (40.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
+ Coverage   18.79%   18.80%   +0.01%     
==========================================
  Files         140      140              
  Lines       27640    27661      +21     
  Branches      980      981       +1     
==========================================
+ Hits         5195     5202       +7     
- Misses      22445    22459      +14     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

Deployed 4608507 to https://ForgeRock.github.io/ping-javascript-sdk/pr-506/460850744caeceacd0395210a094e9ac5f45fddf branch gh-pages in ForgeRock/ping-javascript-sdk

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2025

📦 Bundle Size Analysis

📦 Bundle Size Analysis

🚨 Significant Changes

🔻 @forgerock/journey-client - 0.0 KB (-82.4 KB, -100.0%)

➖ No Changes

@forgerock/device-client - 9.2 KB
@forgerock/oidc-client - 23.4 KB
@forgerock/protect - 150.1 KB
@forgerock/sdk-utilities - 7.5 KB
@forgerock/journey-client - 82.4 KB
@forgerock/sdk-types - 8.0 KB
@forgerock/storage - 1.4 KB
@forgerock/sdk-logger - 1.6 KB
@forgerock/iframe-manager - 2.4 KB
@forgerock/sdk-request-middleware - 4.5 KB
@forgerock/sdk-oidc - 2.6 KB
@forgerock/davinci-client - 39.6 KB


13 packages analyzed • Baseline from latest main build

Legend

🆕 New package
🔺 Size increased
🔻 Size decreased
➖ No change

ℹ️ How bundle sizes are calculated
  • Current Size: Total gzipped size of all files in the package's dist directory
  • Baseline: Comparison against the latest build from the main branch
  • Files included: All build outputs except source maps and TypeScript build cache
  • Exclusions: .map, .tsbuildinfo, and .d.ts.map files

🔄 Updated automatically on each push to this PR

@ryanbas21 ryanbas21 force-pushed the changeset-release/main branch from 2361b54 to efc6acb Compare January 12, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants