chore: move-to-legacy-mark-when-server-not-up #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ancheetah
reviewed
Jan 7, 2026
Comment on lines
+10
to
+11
| "./Archived/angular-todo-davinci/", | ||
| "./Archived/embedded-login-davinci/", |
Contributor
There was a problem hiding this comment.
Why are we keeping these in the workspaces if they are now archived?
Contributor
Author
There was a problem hiding this comment.
I was thinking to keep them functional, otherwise they won't be installed or runnable without extra steps
ancheetah
previously approved these changes
Jan 7, 2026
cerebrl
requested changes
Jan 12, 2026
Contributor
cerebrl
left a comment
cerebrl
left a comment
There was a problem hiding this comment.
I think this is fine other than the handle of the auth error.
Comment on lines
65
to
70
| const Todos = apiError ? ( | ||
| <div className="alert alert-warning m-3" role="alert"> | ||
| <strong>Unable to load todos:</strong> {apiError} | ||
| </div> |
Contributor
There was a problem hiding this comment.
If we do this, can we provide a rendered link to the login page?
cerebrl
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://pingidentity.atlassian.net/browse/SDKS-4407